Entity location table for DB editor #3203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3203 +/- ##
==========================================
+ Coverage 68.83% 69.00% +0.17%
==========================================
Files 198 198
Lines 38342 38583 +241
Branches 4596 4631 +35
==========================================
+ Hits 26391 26626 +235
- Misses 10643 10647 +4
- Partials 1308 1310 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
soininen
force-pushed
the
3088_entity_location_table
branch
from
b2636a5 to
f90a865
Compare
The models should not know anything about dock widgets. The bookkeeping has been moved to SpineDBEditor where it rightfully belongs.
- New Entity table contains all fields available in entities. The table currently lacks the empty table, so only updates are supported. - Models now use field maps as the definitive source for available fields, field order and headers. Re #3088
The fact that SpineDBManager.can_fetch_more() also registers the fetch parent is very surprising and we should get rid of the feature. This is a step towards that: compound table models now explicitly register and unregister fetch parents when their database mappings change. This simplifies canFetchMore() method considerably.
…table Entity table now has proper delegates, copy/paste data converters and SingleEntityTableModel.data() now returns sane data. Re #3088
…ames immutable Entity table shouldn't create entities on the fly as it is very confusing. Also, make the entity_byname field fixed for 0-dimensional entities as modifying this field doesn't really make much sense. To rename entities, the "name" field can be used. Re #3088
Empty Entity alternative table is now consistent with Parameter value table. Re #3088
Less conversions between field <-> column index <-> header. Re #3088
The validation process could end up in an endless loop as proved by the unit tests. This should fix the issue. Re #3088
invalidateFilter() should be replaced by beginFilterChange() and endFilterChange(). Further, invalidateFilter() is a protected method in C++, not a slot, so we shouldn't connect a signal to it. Re #3088
QSortFilterProxy.beginFilterChange() and endFilterChange() were introduced in 6.9. Re #3088
soininen
force-pushed
the
3088_entity_location_table
branch
from
2510f51 to
38e581a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dock with an Entity table to Database editor. The table contains all entity data including location entries. Entities can be updated with the table. However, unlike the other stacked tables, Entity table does not have the empty rows and therefore it is not possible to add new entities from it. The feature was omitted because it is not yet clear if the table is useful in its current form.
Resolves #3088
Checklist before merging