Skip to content

Conversation

@soininen
Copy link
Contributor

@soininen soininen commented Oct 30, 2025

The latitude, longitude and altitude fields now accept non-localized numbers properly and handle Nones gracefully.

Fixes #3207

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

- The input validator now uses regular expressions instead of the
  localized QDoubleValidator --- the number formatting is now consistent
  with the parameter tables.
- None values are now handled gracefully by the delegate.

Re #3207
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.00%. Comparing base (20f7984) to head (fb4811b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...oolbox/spine_db_editor/widgets/custom_delegates.py 36.36% 7 Missing ⚠️
...oolbox/spine_db_editor/widgets/graph_view_mixin.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3208      +/-   ##
==========================================
- Coverage   69.00%   69.00%   -0.01%     
==========================================
  Files         198      198              
  Lines       38583    38588       +5     
  Branches     4631     4631              
==========================================
+ Hits        26626    26628       +2     
- Misses      10647    10650       +3     
  Partials     1310     1310              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soininen soininen merged commit f8d0acf into master Oct 30, 2025
17 of 19 checks passed
@soininen soininen deleted the 3207_fix_entity_table_delegates branch October 30, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Input delegates are broken in Entity table's coordinate columns

2 participants