Skip to content

Conversation

@soininen
Copy link
Contributor

@soininen soininen commented Oct 31, 2025

The stacked tables now scroll to the new rows and select them when data is added to the database e.g. through the empty rows.

Fixes #3209

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Compound models don't have empty rows anymore.

Re #3209
When non-committed data is added (usually from them empty tables),
the data tables now scroll such that the last added row is visible,
and select all added rows. This should give some visual cue of
what happened.

Re #3209
fixed_columns had a wrong index for the entity class name column
in Parameter definition table.

Re #3209
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.02%. Comparing base (f8d0acf) to head (127213d).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...olbox/spine_db_editor/mvcmodels/compound_models.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
+ Coverage   69.00%   69.02%   +0.01%     
==========================================
  Files         198      198              
  Lines       38588    38608      +20     
  Branches     4631     4633       +2     
==========================================
+ Hits        26628    26649      +21     
  Misses      10650    10650              
+ Partials     1310     1309       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soininen soininen merged commit 1291796 into master Oct 31, 2025
19 checks passed
@soininen soininen deleted the 3209_visualize_added_rows branch October 31, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show rows added from empty table in the corresponding "main table"

2 participants