Add execution test #3219
Merged
Add execution test #3219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This execution test tests a bug that corrupted databases by not removing database items in cascade. Re spine-tools/Spine-Database-API#594
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3219 +/- ##
=======================================
Coverage 69.03% 69.03%
=======================================
Files 199 199
Lines 38625 38625
Branches 4633 4633
=======================================
Hits 26665 26665
Misses 10651 10651
Partials 1309 1309 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an execution test that tests a bug that corrupted databases when removing items from filtered databases. The bug has been fixed in spine-tools/Spine-Database-API#597
Re spine-tools/Spine-Database-API#594
Checklist before merging