Fix bugs with multiple databases in single database editor tab #3222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch parents must be marked as fetched when 1. The datbase is fully fetched 2. There are no external commits 3. The mapping has been iterated through This fixes a situation where busy and forever unfetched fetch parents would block the closing of a DB in DB worker. Re #3221
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3222 +/- ##
==========================================
- Coverage 69.05% 69.04% -0.01%
==========================================
Files 199 199
Lines 38643 38642 -1
Branches 4633 4632 -1
==========================================
- Hits 26683 26682 -1
Misses 10651 10651
Partials 1309 1309 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues in Database editor when more than one database is open in a single tab:
Fixes #3151,#3221
Checklist before merging