Exclude PySide6 6.10.1 from pyproject.toml #3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6.10.1 has signal connection issues that cannot be fixed in a reasonable way. Re #3223
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3224 +/- ##
=======================================
Coverage 69.04% 69.05%
=======================================
Files 199 199
Lines 38642 38653 +11
Branches 4632 4632
=======================================
+ Hits 26682 26692 +10
- Misses 10651 10652 +1
Partials 1309 1309 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PySide6 6.10.1 has signal connection issues that cannot be fixed in a reasonable way. E.g. connecting
QAbstractItemMode.dataChangedto a perfectly valid slot causes a segfault.Resolves #3223
Checklist before merging