Do not rely on commit_id when sorting parameter value lists #3233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sorting depended on "commit_id" being non-null, which is usually the case, but there seem to be databases where this doesn't hold. In any case, it is better to rely on PublicItem.is_committed(). Re #1901
soininen
force-pushed
the
1901_fix_value_list_sorting
branch
from
271b03e to
bc195a5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3233 +/- ##
=======================================
Coverage 70.02% 70.02%
=======================================
Files 202 202
Lines 39080 39080
Branches 4725 4725
=======================================
Hits 27365 27365
Misses 10412 10412
Partials 1303 1303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit_idshould not be null, but it may be. Better usePublicItem.is_committed()which is much more reliable.Fixes #1901
Checklist before merging