Store link arrows' filter settings into the local settings file #3239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProjectUpgrader contained a reference to ToolboxUI instance for logging purposes which prevented its usage in the headless mode. Further, the class consitest mostly of static methods which raises the question why do we need a dedicated class at all. - ProjectUpgrader class has now been replaced by free functions most of which are the static methods from ProjectUpgrader. - The functions do not depend on ToolboxUI meaning they can be used in headless mode, or moved to Spine Engine in the distant future. Re #2509
The goal here was to share a much as possible code between the headless model, ToolboxUI, Project and plugins. A secondary goal was to break the functions into more easily testable pieces. Re #2509
5 tasks
soininen
force-pushed
the
2509_make_filter_settings_local
branch
from
30393e7 to
8762ae9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3239 +/- ##
==========================================
+ Coverage 70.01% 70.20% +0.19%
==========================================
Files 202 204 +2
Lines 39084 39103 +19
Branches 4725 4721 -4
==========================================
+ Hits 27364 27453 +89
+ Misses 10416 10354 -62
+ Partials 1304 1296 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolbox now stores the selected filters of link arrows into
<project root>/.spinetoolbox/local/project_local_data.json.Besides that, this PR contains a large refactoring of project loading and upgrading code where the goal has been to share as much code as possible between the headless mode and GUI. Perhaps the most impactful user-facing change is that the headless mode now upgrades the project just like Toolbox would do. Previously, upgrading was disabled in the headless mode since the code depended on instantiating the main window.
Re #2509
Checklist before merging