Skip to content

Conversation

@soininen
Copy link
Contributor

@soininen soininen commented Dec 18, 2025

This PR fixes a Traceback that would appear when selecting the "Type new scenario name here..." item in Scenario tree.

No associated issue.

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

ScenarioSelectionForFiltering now correctly ignores model indexes
that give None for scenario id.
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.26%. Comparing base (6409f80) to head (4416ea7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3247      +/-   ##
==========================================
- Coverage   70.26%   70.26%   -0.01%     
==========================================
  Files         204      204              
  Lines       39127    39129       +2     
  Branches     4722     4723       +1     
==========================================
  Hits        27494    27494              
- Misses      10334    10335       +1     
- Partials     1299     1300       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soininen soininen merged commit b39050a into master Dec 18, 2025
34 of 36 checks passed
@soininen soininen deleted the fix_traceback_from_scenario_selection branch December 18, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants