Fix adding entity classes when multiple databases are open in an editor tab #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a global busy flag prevents simultaneous fetching of multiple databases at once.
Sort key cannot contain Nones which was the case for classes that don't have a superclass. This issues was hit when sorting classes from different databases with same name (and dimensions) but one had a superclass and the other one didn't.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3249 +/- ##
==========================================
+ Coverage 70.20% 70.21% +0.01%
==========================================
Files 204 204
Lines 39206 39214 +8
Branches 4728 4729 +1
==========================================
+ Hits 27525 27535 +10
+ Misses 10382 10381 -1
+ Partials 1299 1298 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where it was not possible to add an entity class with same name as another entity class in different database that was open in the same DB editor tab if the existing class had a superclass.
No associated issue.
Checklist before merging