Show all dependent items on stacked tables #3251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ships Superclasses and relationships-of-relationships have existed for quite some time already. Still, the stacked tables showed only the first level of related relationships. This commit finally brings in the entire relationship tree (accounting for superclasses, too) when considering what to show in the tabular views. To achieve this, DB manager now lazily chaches entity class and entity trees as networkx Graphs. We treat superclassess as relationships of their subclasses which works for the filtering purposes. The graphs allows us to easily track if an entity (class) is an element (or part of an element) of a relationship, no matter how deep the relationship tree is or how many superclasses there are on the way. Re #3242
Previously, when selecting entities or anything deeper than entity classes in Entity tree, all the selected item's parent items were used for filtering as well. This didn't work very well now that we show everything concerning the selected entity including relationships-of-relationships in the stacked tables. Instead, only the selected entities are used for the filtering. Re #3242
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3251 +/- ##
==========================================
+ Coverage 70.21% 70.24% +0.03%
==========================================
Files 204 205 +1
Lines 39222 39286 +64
Branches 4731 4744 +13
==========================================
+ Hits 27539 27597 +58
- Misses 10385 10388 +3
- Partials 1298 1301 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the stacked tables showed extra items that were in direct relationship with the selected entity in the Entity tree. With this PR, also all relationship-of-relationship items are show in the tables.
Fixes #3242
Checklist before merging