added step to check make has been run or not #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: swastik959 <[email protected]>
swastik959
requested review from
endocrimes,
bacongobbler and
michelleN
as code owners
Signed-off-by: swastik959 <[email protected]>
calebschoepp
approved these changes
May 30, 2025
bacongobbler
approved these changes
May 30, 2025
|
Wonderful! Looks like the test failed because some files are out of date. @swastik959 would you mind regenerating those files as well and adding them to this PR? That would be really appreciated. Thank you! |
Signed-off-by: swastik959 <[email protected]>
@bacongobbler done |
bacongobbler
requested changes
Jun 2, 2025
Signed-off-by: swastik959 <[email protected]>
|
@bacongobbler please have a look |
Signed-off-by: swastik959 <[email protected]>
Signed-off-by: swastik959 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added step to check make has been run or not in the build workflow
solves #342