Emit otel metrics directly instead of through tracing - #3623
Open
rylev wants to merge 2 commits into
Open
Conversation
Signed-off-by: Ryan Levick <rlevick@akamai.com>
lann
reviewed
Jul 17, 2026
Collaborator
This seems more robust than what tracing-opentelemetry does anyway: https://docs.rs/tracing-opentelemetry/latest/tracing_opentelemetry/struct.MetricsLayer.html#floating-point-numbers |
lann
reviewed
Jul 17, 2026
lann
reviewed
Jul 17, 2026
lann
reviewed
Jul 17, 2026
lann
left a comment
Collaborator
There was a problem hiding this comment.
Minor quibbles. I think this is better than tracing.
lann
approved these changes
Jul 17, 2026
lann
reviewed
Jul 17, 2026
| pub use propagation::extract_trace_context; | ||
| pub use propagation::inject_trace_context; | ||
|
|
||
| /// Initializes telemetry for Spin using the [tracing] library. |
Collaborator
There was a problem hiding this comment.
I suppose this should be updated to mention that it sets the global metrics provider. An LLM might read it...
calebschoepp
approved these changes
Jul 17, 2026
calebschoepp
left a comment
Collaborator
There was a problem hiding this comment.
I like this approach a lot more
rylev
force-pushed
the
direct-otel-metrics
branch
from
July 28, 2026 15:55
869e2a3 to
b22447f
Compare
Signed-off-by: Ryan Levick <rlevick@akamai.com>
rylev
force-pushed
the
direct-otel-metrics
branch
from
July 28, 2026 15:58
b22447f to
625b120
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #3619
Instead of doing some compile time magic, we instead get rid of our dependency on
tracingfor emitting metrics and instead emit the otel metrics directly.This does require duplicating macros to specify types as as far as I can tell we can't infer the type param we need to pass to the
opentelemetry::metricstypes.I also deleted some tests in crates/connection-semaphore/src/lib.rs where were testing that we were emitting specific metrics. This is harder to test with the new implementation, and I'm not convinced we actually got that much out of those tests.