Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective Deployments Tutorial #259

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

macolso
Copy link
Contributor

@macolso macolso commented Nov 8, 2024

A basic tutorial that walks users through how to scaffold and run a selective deployment using the salutations sample app from @kate-goldenring .

Few outstanding todos

  • Update Spin App CR once salutations OCI artifact gets revved
  • Check that the formatting on spin kube scaffold --component is correct. It currently doesn't match what we've been using manually (@bacongobbler ). I could be making a mistake somewhere along the way
  • Include output from port forwarding test at the end

Resolves #258

Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the texts looks great -- only nits. Only blocker is the shim version needs to change

@macolso macolso marked this pull request as ready for review November 10, 2024 20:51
Signed-off-by: macolso <[email protected]>
@endocrimes endocrimes merged commit 7044ca5 into spinframework:main Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial: Selective Deployments
3 participants