Skip to content
This repository was archived by the owner on Dec 20, 2025. It is now read-only.

fix: Should fix the deletion of permissions when resource name is uppercase (backport #1012) #1014

Merged
mergify merged 1 commit into from
Feb 7, 2023
Merged

fix: Should fix the deletion of permissions when resource name is uppercase (backport #1012) #1014

mergify merged 1 commit into from
Feb 7, 2023

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2023

This is an automatic backport of pull request #1012 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@ovidiupopa07 @mergify
fix: Should fix the deletion of permissions when resource name is upp…
9c67de2 
…ercase (#1012)

After the update to make all resource names lowercase, the user role sync process deletes the permission if the resource name (provided by the ResourceProvider) is in uppercase and the one in DB is in lowercase.

(cherry picked from commit 6d4bcfc)
@mergify mergify bot requested review from cfieber and jonsie as code owners February 7, 2023 14:59
@mergify mergify bot mentioned this pull request Feb 7, 2023
Merged
@jasonmcintosh jasonmcintosh added ready to merge Approved and ready for merge and removed ready to merge Approved and ready for merge labels Feb 7, 2023
@mergify mergify bot added the auto merged label Feb 7, 2023
@mergify mergify bot merged commit 6d9f505 into release-1.29.x Feb 7, 2023
@mergify mergify bot deleted the mergify/bp/release-1.29.x/pr-1012 branch February 7, 2023 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cfieber cfieber Awaiting requested review from cfieber cfieber is a code owner

@jonsie jonsie Awaiting requested review from jonsie jonsie is a code owner

1 more reviewer

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto merged ready to merge Approved and ready for merge target-release/1.29

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasonmcintosh @spinnakerbot @ovidiupopa07