Added support for IAP to roer #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2021 22:23
This allows settings IAP Bearer token in env variable, or pass an --iap flag with the token.
There were two methods that used direct httpClient instead of the overridden one.
Author
|
I know this repo isn't being maintained anymore, since roer is EOL, but I thought it may be of benefit to others too. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work with roer using IAP, I've added this support.
It works either by setting a flag --iap and pasting the bearer token, or having the bearer token in environment variable $SPINNAKER_IAP_TOKEN.
In order to generate the token, there are several ways, either by using a service account JSON file, or by oauth web authentication with client ID and secret.
It's out of this code's scope, and therefore not added.