Add a button to load config from notebook, rather than silently overwritting settings.#40
Add a button to load config from notebook, rather than silently overwritting settings.#40tomprince wants to merge 2 commits intospirit-island:betafrom
Conversation
Note that this is (I think) different that the original implementation (I think). That had a toggle for whether to load the data. This instead loads the data immediately when you click the button, letting the settings be visible and changeable. |
|
What if instead of a button it auto loads the settings in? Just setup a timer that will periodically check the notebook tab? |
|
I do think that overwritting settings automatically is not user friendly. Whether you do it when you press start, or on a timer. |
Thinking about this further, my objection is only if a player has made any change to a config. So if we tracked if any changes have been made, and only loaded automatically if there were none, and then had a button to load otherwise, I think that would be be reasonable. |
|
(filed https://tabletopsimulator.nolt.io/573 to get an event, so we wouldn't need to poll) |
There are a couple of things I would like to improve before landing:
Also, I'm not sure if the place I put the button is best from a UI design.
This is #36 rebased on the rewritten commits.