Open
Conversation
D:\code\qt\Dwarf-Therapist\src\grid_view\rolecolumn.cpp:107:
Author
|
Hi, this fix just allow to compile code using VS 2015/2017 (at current branch DF2016 this remeains). |
TV4Fun
reviewed
Jul 21, 2017
| char buf[len]; | ||
| read_raw(buffer_addr, len, buf); | ||
| return QTextCodec::codecForName("IBM437")->toUnicode(buf, len); | ||
| std::unique_ptr<char[]> buf = std::make_unique<char[]>(len); |
There was a problem hiding this comment.
As discussed in #320, we want to avoid doing heap allocation in a hot path. The fix I have pending avoids heap allocation and uses VLAs if supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.