Add file upload overwrite#248
Open
jkuroda wants to merge 2 commits into
Open
Conversation
…le that already exists at the same namespace:filename * add "overwrite" to standardArgs()' list of known constraints in helper/field.php * add "overwrite" to helper_plugin_bureaucracy_fieldfile's initialization function * parameterize hardcoded "false" of media_save's $ow arg in processUploads() in helper/actiontemplate.php
…ite" get interpreted as a namespace by the rest of the bureaucracy plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, processUploads() in helper/actiontemplate.php hardcodes media_save()'s $ow argument to false which prevents one from overwriting an already existing file uploaded to the same namespace via a form created using Bureaucracy's "file" field type, even when one wants to allow this.
I needed this in a hurry last night, so I added an "%overwrite" parameter to the line field type that goes after the optional namespace. I'm not tied to the particular name for the parameter - I just needed something that would be easy to track down later, and I prepended "%" to it keep the rest of the plugin from interpreting it as a namespace (especially in helper_plugin_bureaucracy_fieldfile's initialize() function).