introduce action_whitelist. Admins can allow limited set of form-actions#358
Open
btittelbach wants to merge 1 commit into
Open
introduce action_whitelist. Admins can allow limited set of form-actions#358btittelbach wants to merge 1 commit into
btittelbach wants to merge 1 commit into
Conversation
…n forms. E.g. forbid e-mail and script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The form extension is quite useful, but allows any user that can create a page somewhere to send e-Mails or run php script files (well, it still somewhat allows this even after this merge request, using the substitution syntax).
Admins might want to restrict the available actions to those they deem safe.
e.g. in Environments where a dokuwiki is closed but has many users with different ACLs.
This patch introduces a configuration variable "action_whitelist" and takes an array of actions to allow.
The empty array, disables all restrictions and restores previous behaviour of allowing all actions.
It's been tested successfully against dokuwiki 2024-02-06b "Kaos".