Skip to content

Conversation

@hetangmodi-crest
Copy link
Contributor

@hetangmodi-crest hetangmodi-crest commented Sep 22, 2025

Issue number: Issue #1913 ADDON-83527

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

Previously, when a user specified a custom build path using the --o/--output parameter, the entire output_path was cleaned before building the add-on. This could result in unintended loss of existing files in that directory.

Therefore, added a new flag--overwrite for the build command. Now, we only attempt to clean the output_path/<ta_name> directory if the --overwrite flag is provided. If the --overwrite flag is not passed and the output_path/<ta_name> directory already exists, the build will fail and prompt the user to either pass the --overwrite flag or choose a different output path.

User experience

User files and directories will no longer be unintentionally deleted when a custom build path is provided using the --o/--output parameter. If the output_path/<ta_name> directory already exists, users must explicitly pass the --overwrite flag to allow it to be overwritten.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@hetangmodi-crest hetangmodi-crest self-assigned this Sep 22, 2025
@hetangmodi-crest hetangmodi-crest added the enhancement New feature or request label Sep 22, 2025
@hetangmodi-crest hetangmodi-crest marked this pull request as ready for review September 23, 2025 05:42
@hetangmodi-crest hetangmodi-crest requested review from a team as code owners September 23, 2025 05:42
Base automatically changed from ucc-6-0-0 to develop September 25, 2025 12:48
@kkedziak-splunk kkedziak-splunk dismissed their stale review September 25, 2025 12:48

The base branch was changed.

@github-actions
Copy link

Code Coverage 🎉

Type PR Develop Change Status
Line Coverage 94.33% 94.32% 0.01% 🟢 Increased
Branch Coverage 90.78% 90.83% 0.04% 🔴 Decreased

@hetangmodi-crest hetangmodi-crest merged commit 1dab3ae into develop Sep 29, 2025
81 checks passed
@hetangmodi-crest hetangmodi-crest deleted the feat/do-not-delete-from-output-dir branch September 29, 2025 12:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants