Skip to content

Conversation

@CheraghiMilad
Copy link
Contributor

@CheraghiMilad CheraghiMilad commented Aug 28, 2025

Details

What does this PR have in it? Screenshots are worth 1000 words 😄
Resolved a potential detection bypass for Magic SysRq abuse, where auditd events could be missed if SysRq was triggered via different paths. Validated detection using sample auditd logs in a test Linux environment.

dataset is splunk/attack_data#1019

Running the following commands to trigger SysRq events:

echo b > /proc/sysrq-trigger
echo c > /proc/sysrq-trigger

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the the date and version in the associated YAML file.

@patel-bhavin
Copy link
Contributor

@CheraghiMilad : Thank you for this PR - I have made some comments on this PR and the attack data PR. PLease let us know if you have questions

@CheraghiMilad
Copy link
Contributor Author

@CheraghiMilad : Thank you for this PR - I have made some comments on this PR and the attack data PR. PLease let us know if you have questions

Thanks for your help. I think everything is clear now.

@patel-bhavin patel-bhavin added this to the v5.14.0 milestone Sep 3, 2025
@patel-bhavin
Copy link
Contributor

patel-bhavin commented Sep 3, 2025

Testing against the attack data looks good! Thank you for contributing all the required pieces for this detection!

Ignore the app inspect failures as it does not work on PRs from forks.

image

@patel-bhavin patel-bhavin merged commit 8a3d8a5 into splunk:develop Sep 3, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants