Skip to content

fix: delete redis from bitnami and provide own templates #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
omrozowicz-splunk merged 21 commits into from
Oct 27, 2025
Merged

fix: delete redis from bitnami and provide own templates #1267

omrozowicz-splunk merged 21 commits into from
Oct 27, 2025

Conversation

@omrozowicz-splunk
Copy link
Contributor

@omrozowicz-splunk omrozowicz-splunk commented Oct 13, 2025 •
edited
Loading

Description

This PR:

  1. Removes bitnami redis dependency
  2. Upgrade redis version to the newest
  3. Add redis authentication — both plain text and secret

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Dependency update
  • Refactor/improvement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual tests, integration tests

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@omrozowicz-splunk omrozowicz-splunk marked this pull request as ready for review October 14, 2025 12:57
Kawron
Kawron requested changes Oct 16, 2025
View reviewed changes
Kawron
Kawron reviewed Oct 16, 2025
View reviewed changes
@omrozowicz-splunk
fix: delete redis from bitnami and provide own templates
cfd11e0
@omrozowicz-splunk
fix: update integration tests redis image for docker-compose [run-int…
8e44b4f 
…-tests]
@omrozowicz-splunk
fix: update trap deployment with REDIS env variables [run-int-tests]
46f4a40
@omrozowicz-splunk
fix: update trap deployment with REDIS env variables [run-int-tests]
b6781ab
@omrozowicz-splunk
fix: tmp docker-compose logs [run-int-tests]
5d5c085
@omrozowicz-splunk
fix: tmp docker-compose logs [run-int-tests]
4394e10
@omrozowicz-splunk
fix: update entrypoint.sh shell script with the fallback for docker […
070fd84 
…run-int-tests]
@omrozowicz-splunk
fix: remove logger helper
22693dd
@omrozowicz-splunk
fix: update UI redis_url
a84f3c0
@omrozowicz-splunk
fix: ui backend env variables
253fa14
@omrozowicz-splunk
test: update UI image version [run-ui-tests]
25e70dd
@omrozowicz-splunk
test: mount volume to avoid splunk errors [run-ui-tests]
c7eddbd
@omrozowicz-splunk
test: increase minFreeSpace to fix splunk errors [run-ui-tests]
60bf869
@omrozowicz-splunk
test: increase minFreeSpace to fix splunk errors [run-ui-tests]
e32706c
@omrozowicz-splunk
test: decrease minFreeSpace to fix splunk errors [run-ui-tests]
2ec901d
@omrozowicz-splunk
test: work on ui tests
9e36282
@omrozowicz-splunk
test: test new version of SC4SNMP-UI backend [run-ui-tests]
3fa9c97
@omrozowicz-splunk
test: bring back tests [run-ui-tests]
55f87bc
ajasnosz
ajasnosz requested changes Oct 27, 2025
View reviewed changes
@omrozowicz-splunk omrozowicz-splunk merged commit 32ce431 into develop Oct 27, 2025
13 of 14 checks passed
@omrozowicz-splunk omrozowicz-splunk deleted the fix/update-redis-chart branch October 27, 2025 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2025
@srv-rr-github-token
Copy link
Contributor

srv-rr-github-token commented Oct 27, 2025

🎉 This PR is included in version 1.14.2-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Kawron Kawron Kawron requested changes

@ajasnosz ajasnosz ajasnosz approved these changes

@cwadhwani-splunk cwadhwani-splunk Awaiting requested review from cwadhwani-splunk

+1 more reviewer

@mattk42 mattk42 mattk42 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released on @beta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@omrozowicz-splunk @srv-rr-github-token @mattk42 @Kawron @ajasnosz