Skip to content

Conversation

@tigrannajaryan
Copy link
Collaborator

@tigrannajaryan tigrannajaryan commented Aug 26, 2025

This should supposedly fix the build error:
https://github.com/splunk/stef/actions/runs/17238794587/job/48910819037

Change generated by Copilot.

@github-actions
Copy link

Benchmark Result

Benchmark diff with base branch
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │     sec/op     │    sec/op     vs base               │
SerializeNative/STEF/none-4                           14.48m ± 6%   12.79m ±  8%  -11.65% (p=0.026 n=6)
SerializeNative/STEFU/none-4                          43.59m ± 1%   41.89m ±  2%   -3.90% (p=0.002 n=6)
DeserializeNative/STEF/none-4                         2.886m ± 1%   2.882m ±  1%        ~ (p=0.818 n=6)
DeserializeNative/STEFU/none-4                        11.70m ± 1%   11.66m ±  2%        ~ (p=0.485 n=6)
SerializeFromPdata/STEF/none-4                        224.1m ± 3%   209.0m ±  2%   -6.73% (p=0.002 n=6)
SerializeFromPdata/STEFU/none-4                       43.80m ± 2%   42.68m ±  4%   -2.55% (p=0.004 n=6)
DeserializeToPdata/STEF/none-4                        43.78m ± 3%   44.02m ±  3%        ~ (p=0.937 n=6)
DeserializeToPdata/STEFU/none-4                       68.59m ± 1%   67.64m ±  1%   -1.38% (p=0.026 n=6)
STEFReaderRead-4                                      2.901m ± 2%   2.871m ±  2%        ~ (p=0.589 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4         3.885 ± 8%    3.864 ± 10%        ~ (p=0.589 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4      92.46m ± 2%   90.52m ± 26%        ~ (p=0.310 n=6)
ReadSTEF-4                                            2.945m ± 1%   2.978m ±  1%        ~ (p=0.180 n=6)
ReadSTEFZ-4                                           4.769m ± 3%   4.844m ±  1%   +1.57% (p=0.041 n=6)
ReadSTEFZWriteSTEF-4                                  9.339m ± 1%   9.365m ±  1%        ~ (p=0.394 n=6)
geomean                                               26.54m        26.01m         -1.98%

                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │   sec/point    │  sec/point    vs base               │
SerializeNative/STEF/none-4                           216.6n ± 6%   191.3n ±  8%  -11.66% (p=0.026 n=6)
SerializeNative/STEFU/none-4                          651.9n ± 1%   626.5n ±  2%   -3.90% (p=0.002 n=6)
DeserializeNative/STEF/none-4                         43.16n ± 1%   43.10n ±  1%        ~ (p=0.781 n=6)
DeserializeNative/STEFU/none-4                        175.0n ± 1%   174.4n ±  2%        ~ (p=0.459 n=6)
SerializeFromPdata/STEF/none-4                        3.351µ ± 3%   3.126µ ±  2%   -6.73% (p=0.002 n=6)
SerializeFromPdata/STEFU/none-4                       654.9n ± 2%   638.2n ±  4%   -2.55% (p=0.004 n=6)
DeserializeToPdata/STEF/none-4                        654.6n ± 3%   658.3n ±  3%        ~ (p=0.937 n=6)
DeserializeToPdata/STEFU/none-4                       1.026µ ± 1%   1.012µ ±  1%   -1.32% (p=0.030 n=6)
STEFReaderRead-4                                      43.38n ± 2%   42.93n ±  2%        ~ (p=0.589 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4        4.938µ ± 8%   4.911µ ± 10%        ~ (p=0.589 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4      117.5n ± 2%   115.1n ± 26%        ~ (p=0.288 n=6)
ReadSTEF-4                                            44.08n ± 1%   44.57n ±  1%        ~ (p=0.180 n=6)
ReadSTEFZ-4                                           71.37n ± 3%   72.49n ±  1%   +1.58% (p=0.041 n=6)
ReadSTEFZWriteSTEF-4                                  139.8n ± 1%   140.2n ±  1%        ~ (p=0.368 n=6)
geomean                                               279.1n        273.6n         -1.97%

                                                 │ bench-main.txt │           bench-new.txt            │
                                                 │      B/op      │     B/op      vs base              │
SerializeNative/STEF/none-4                          3.476Mi ± 0%   3.482Mi ± 0%       ~ (p=0.818 n=6)
SerializeNative/STEFU/none-4                         6.952Mi ± 0%   6.952Mi ± 0%       ~ (p=0.699 n=6)
DeserializeNative/STEF/none-4                        842.3Ki ± 0%   842.3Ki ± 0%       ~ (p=1.000 n=6)
DeserializeNative/STEFU/none-4                       1.466Mi ± 0%   1.466Mi ± 0%       ~ (p=0.545 n=6)
SerializeFromPdata/STEF/none-4                       143.3Mi ± 0%   143.3Mi ± 0%       ~ (p=0.132 n=6)
SerializeFromPdata/STEFU/none-4                      6.952Mi ± 0%   6.952Mi ± 0%       ~ (p=0.699 n=6)
DeserializeToPdata/STEF/none-4                       29.82Mi ± 0%   29.82Mi ± 0%       ~ (p=0.184 n=6)
DeserializeToPdata/STEFU/none-4                      36.53Mi ± 0%   36.53Mi ± 0%       ~ (p=0.106 n=6)
STEFReaderRead-4                                     842.3Ki ± 0%   842.3Ki ± 0%       ~ (p=0.545 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4       3.715Gi ± 0%   3.715Gi ± 0%       ~ (p=0.485 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     20.17Mi ± 0%   20.17Mi ± 0%       ~ (p=0.494 n=6)
ReadSTEF-4                                           842.3Ki ± 0%   842.3Ki ± 0%       ~ (p=0.455 n=6)
ReadSTEFZ-4                                          10.12Mi ± 0%   10.12Mi ± 0%  +0.00% (p=0.026 n=6)
ReadSTEFZWriteSTEF-4                                 13.45Mi ± 0%   13.45Mi ± 0%       ~ (p=0.485 n=6)
geomean                                              10.59Mi        10.59Mi       +0.01%

                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │   allocs/op    │  allocs/op   vs base                │
SerializeNative/STEF/none-4                           2.924k ± 1%   2.935k ± 1%       ~ (p=0.818 n=6)
SerializeNative/STEFU/none-4                          1.101k ± 0%   1.101k ± 0%       ~ (p=1.000 n=6)
DeserializeNative/STEF/none-4                         1.342k ± 0%   1.342k ± 0%       ~ (p=1.000 n=6) ¹
DeserializeNative/STEFU/none-4                        1.403k ± 0%   1.403k ± 0%       ~ (p=1.000 n=6) ¹
SerializeFromPdata/STEF/none-4                        256.4k ± 0%   256.4k ± 0%       ~ (p=0.190 n=6)
SerializeFromPdata/STEFU/none-4                       1.103k ± 0%   1.103k ± 0%       ~ (p=1.000 n=6)
DeserializeToPdata/STEF/none-4                        623.4k ± 0%   623.4k ± 0%       ~ (p=1.000 n=6) ¹
DeserializeToPdata/STEFU/none-4                       812.2k ± 0%   812.2k ± 0%       ~ (p=1.000 n=6) ¹
STEFReaderRead-4                                      1.342k ± 0%   1.342k ± 0%       ~ (p=1.000 n=6) ¹
STEFSerializeMultipart/astronomy-otelmetrics-4        14.44M ± 0%   14.44M ± 0%       ~ (p=0.093 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4      8.402k ± 0%   8.402k ± 0%       ~ (p=1.000 n=6)
ReadSTEF-4                                            1.342k ± 0%   1.342k ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEFZ-4                                           1.375k ± 0%   1.375k ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEFZWriteSTEF-4                                  2.376k ± 0%   2.376k ± 0%       ~ (p=1.000 n=6)
geomean                                               11.39k        11.39k       +0.03%
¹ all samples are equal
Benchmark result
benchstat bench-new.txt
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-new.txt │
                                                 │    sec/op     │
SerializeNative/STEF/none-4                         12.79m ±  8%
SerializeNative/STEFU/none-4                        41.89m ±  2%
DeserializeNative/STEF/none-4                       2.882m ±  1%
DeserializeNative/STEFU/none-4                      11.66m ±  2%
SerializeFromPdata/STEF/none-4                      209.0m ±  2%
SerializeFromPdata/STEFU/none-4                     42.68m ±  4%
DeserializeToPdata/STEF/none-4                      44.02m ±  3%
DeserializeToPdata/STEFU/none-4                     67.64m ±  1%
STEFReaderRead-4                                    2.871m ±  2%
STEFSerializeMultipart/astronomy-otelmetrics-4       3.864 ± 10%
STEFDeserializeMultipart/astronomy-otelmetrics-4    90.52m ± 26%
ReadSTEF-4                                          2.978m ±  1%
ReadSTEFZ-4                                         4.844m ±  1%
ReadSTEFZWriteSTEF-4                                9.365m ±  1%
geomean                                             26.01m

                                                 │ bench-new.txt │
                                                 │   sec/point   │
SerializeNative/STEF/none-4                         191.3n ±  8%
SerializeNative/STEFU/none-4                        626.5n ±  2%
DeserializeNative/STEF/none-4                       43.10n ±  1%
DeserializeNative/STEFU/none-4                      174.4n ±  2%
SerializeFromPdata/STEF/none-4                      3.126µ ±  2%
SerializeFromPdata/STEFU/none-4                     638.2n ±  4%
DeserializeToPdata/STEF/none-4                      658.3n ±  3%
DeserializeToPdata/STEFU/none-4                     1.012µ ±  1%
STEFReaderRead-4                                    42.93n ±  2%
STEFSerializeMultipart/astronomy-otelmetrics-4      4.911µ ± 10%
STEFDeserializeMultipart/astronomy-otelmetrics-4    115.1n ± 26%
ReadSTEF-4                                          44.57n ±  1%
ReadSTEFZ-4                                         72.49n ±  1%
ReadSTEFZWriteSTEF-4                                140.2n ±  1%
geomean                                             273.6n

                                                 │ bench-new.txt │
                                                 │     B/op      │
SerializeNative/STEF/none-4                         3.482Mi ± 0%
SerializeNative/STEFU/none-4                        6.952Mi ± 0%
DeserializeNative/STEF/none-4                       842.3Ki ± 0%
DeserializeNative/STEFU/none-4                      1.466Mi ± 0%
SerializeFromPdata/STEF/none-4                      143.3Mi ± 0%
SerializeFromPdata/STEFU/none-4                     6.952Mi ± 0%
DeserializeToPdata/STEF/none-4                      29.82Mi ± 0%
DeserializeToPdata/STEFU/none-4                     36.53Mi ± 0%
STEFReaderRead-4                                    842.3Ki ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4      3.715Gi ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4    20.17Mi ± 0%
ReadSTEF-4                                          842.3Ki ± 0%
ReadSTEFZ-4                                         10.12Mi ± 0%
ReadSTEFZWriteSTEF-4                                13.45Mi ± 0%
geomean                                             10.59Mi

                                                 │ bench-new.txt │
                                                 │   allocs/op   │
SerializeNative/STEF/none-4                          2.935k ± 1%
SerializeNative/STEFU/none-4                         1.101k ± 0%
DeserializeNative/STEF/none-4                        1.342k ± 0%
DeserializeNative/STEFU/none-4                       1.403k ± 0%
SerializeFromPdata/STEF/none-4                       256.4k ± 0%
SerializeFromPdata/STEFU/none-4                      1.103k ± 0%
DeserializeToPdata/STEF/none-4                       623.4k ± 0%
DeserializeToPdata/STEFU/none-4                      812.2k ± 0%
STEFReaderRead-4                                     1.342k ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4       14.44M ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4     8.402k ± 0%
ReadSTEF-4                                           1.342k ± 0%
ReadSTEFZ-4                                          1.375k ± 0%
ReadSTEFZWriteSTEF-4                                 2.376k ± 0%
geomean                                              11.39k

@tigrannajaryan tigrannajaryan marked this pull request as ready for review August 26, 2025 13:27
@tigrannajaryan tigrannajaryan merged commit e030fae into main Aug 26, 2025
10 checks passed
@tigrannajaryan tigrannajaryan deleted the tigran/fixbuild branch August 26, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants