Improve benchmark outputs to make zstd time/size more prominent #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds zstd sizes to Profile and JSONL examples and makes zstd CPU times visible as a stack bar chart in benchmark.html.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances benchmark outputs to make zstd compression size/time metrics more prominent across the codebase. It adds compressed size reporting to profile and JSONL examples and introduces visual improvements to the benchmark HTML output.
Key changes:
- Added zstd compression metrics to test output displays
- Enhanced benchmark HTML charts to show compression timing as stacked bar charts
- Modified chart generation to support stacked bars for better visualization of compression overhead
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/profile/pprof2stef_test.go | Added zstd compression comparison between pprof and STEF formats |
| examples/jsonl/json2stef_test.go | Added compressed size columns to JSON/Protobuf/STEF comparison output |
| docs/benchmarks.html | Updated chart IDs and configuration to use stacked bar visualization |
| benchmarks/size_test.go | Modified chart recording to use new stacked bar format |
| benchmarks/charts.go | Enhanced chart system to support multi-series stacked bars |
| benchmarks/benchmarks_test.go | Restructured benchmarks to separate compression timing and show as stacked bars |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Benchmark ResultBenchmark diff with base branchBenchmark result |
maheshkanote
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds zstd sizes to Profile and JSONL examples:
Also makes zstd CPU times visible as a stack bar chart in benchmark.html, for example:
