Generate stefz test files from base version #143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds zstd sizes to Profile and JSONL examples: ``` File --> Size in bytes | JSON | Protobuf | STEF | JSONZ | ProtoZ | stefz currencies_historical | 4197 | 4393 (1.05x) | 1082 (0.26x) | 756 | 1105 | 782 macosx_releases | 2449 | 2604 (1.06x) | 935 (0.38x) | 523 | 766 | 596 programming_languages_keywords | 10681 | 11912 (1.12x) | 8225 (0.77x) | 3746 | 5074 | 4053 File | pprof | stef | pprofz | stefz deser_stef.prof | 83343 | 83768 | 33326 | 29424 (1.005x/0.883x) otelcol_otlp.prof | 31864 | 38859 | 13054 | 9215 (1.220x/0.706x) wsstreamasync.prof | 92996 | 128295 | 29093 | 28150 (1.380x/0.968x) ``` Also makes zstd CPU times visible as a stack bar chart in benchmark.html.
Benchmark ResultBenchmark diff with base branchBenchmark result |
Instead of storing stefz in git we generate them before tests. The files are fairly large and we store large delta everytime the format changes. Files are now deleted from git. otlp2stef tool is used to generate stefz files from OTLP .pb files that don't change. We also use a script to check compatibility of a format. The script checks out old version of otlp2stef, generates files from that, check outs current version of code and runs new test code on old files.
tigrannajaryan
force-pushed
the
tigran/checkcompat
branch
from
f290690 to
bd29737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT. Don't review.