Generate stefz files for testing #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of storing stefz in git we generate them before tests. The files are fairly large and we store large delta everytime the format changes. Files are now deleted from git. otlp2stef tool is used to generate stefz files from OTLP .pb files that don't change. We also use a script to check compatibility of a format. The script checks out old version of otlp2stef, generates files from that, check outs current version of code and runs new test code on old files.
tigrannajaryan
force-pushed
the
tigran/genstefzfiles
branch
from
cc7335b to
faea225
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the test file management approach by generating .stefz test files on-demand instead of storing them in git, addressing issues with large binary files and frequent format changes.
- Removes .stefz files from git tracking and generates them from .zst source files using the otlp2stef tool
- Adds compatibility testing scripts to validate format compatibility between versions
- Updates file paths across the codebase to reference the new generated test files location
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| makefile | Updates build-ci target to use new benchmarks build-ci command |
| java/src/test/java/tests/ReadWriteTest.java | Updates test file path to reference generated directory |
| java/src/main/java/net/stef/benchmarks/STEF.java | Updates benchmark file path to reference generated directory |
| benchmarks/testdata/.gitignore | Ignores the generated test files directory |
| benchmarks/scripts/gentestfiles.sh | New script to generate .stefz files from .zst sources |
| benchmarks/scripts/genoldtestfiles.sh | New script for compatibility testing with old format versions |
| benchmarks/readwrite_test.go | Updates test file paths to reference generated directory |
| benchmarks/makefile | Adds test file generation targets and compatibility testing |
| .github/workflows/build-and-test.yml | Adds test file generation steps to CI workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Benchmark ResultBenchmark diff with base branchBenchmark result |
maheshkanote
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing stefz in git we generate them before tests. The files are fairly large and we store large delta everytime the format changes.
Files are now deleted from git. otlp2stef tool is used to generate stefz files from OTLP .pb files that don't change.
We also use a script to check compatibility of a format. The script checks out old version of otlp2stef, generates files from that, check outs current version of code and runs new test code on old files.