Update benchmark charts #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates benchmark charts with new measurement data by refactoring the traces benchmark test and adding support for conditional attribute sorting based on a sorted parameter. The changes integrate a sorted flag into the span conversion process and reorganize test structure for better chart generation.
- Added sorted parameter to span2span function to conditionally use MapSorted vs MapUnsorted for attributes
- Restructured TestTracesMultipart to generate charts and moved it to end of file
- Updated benchmark HTML with new chart IDs and measurement values
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/pdata/traces/otlp2stef.go | Adds sorted parameter to span2span function for conditional attribute mapping |
| docs/benchmarks.html | Updates chart IDs, measurement data, and adds new trace benchmark sections |
| benchmarks/size_test.go | Refactors TestTracesMultipart for chart generation and moves to end of file |
| benchmarks/makefile | Updates test pattern to include trace tests with longer benchmark time |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Benchmark ResultBenchmark diff with base branchBenchmark result |
tigrannajaryan
force-pushed
the
tigran/updatecharts
branch
2 times, most recently
from
96c660a to
5e14c34
Compare
maheshkanote
approved these changes
Sep 25, 2025
Also include trace size in the charts.
tigrannajaryan
force-pushed
the
tigran/updatecharts
branch
from
5e14c34 to
1c54a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also include trace size in the charts.