Skip to content

Conversation

@tigrannajaryan
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares release 0.0.8 by updating version references across all Go modules from v0.0.7 to v0.0.8.

  • Updates internal package references to use version 0.0.8
  • Improves the release automation workflow in the makefile
  • Adds proper working directory configuration for test execution

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
stefc/go.mod Updates pkg dependency to v0.0.8 and removes unused indirect dependencies
stefc/generator/testdata/go.mod New test module with v0.0.8 dependency
stefc/generator/generator_test.go Fixes test execution by setting proper working directory
otelcol/go.mod Updates grpc, otel, and pkg dependencies to v0.0.8
makefile Enhances release automation with better module handling and dependency management
go/pdata/go.mod Updates otel and pkg dependencies to v0.0.8
go/otel/go.mod Updates grpc and pkg dependencies to v0.0.8
go/grpc/go.mod Updates pkg dependency to v0.0.8
examples/profile/go.mod Updates pkg dependency and reorganizes direct/indirect dependencies
examples/jsonl/go.mod Updates pkg dependency to v0.0.8
benchmarks/go.mod Updates otel and pkg dependencies to v0.0.8

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tigrannajaryan tigrannajaryan marked this pull request as ready for review September 25, 2025 03:22
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

Benchmark Result

Benchmark diff with base branch
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │     sec/op     │    sec/op     vs base               │
SerializeNative/STEF/serialize-4                     7.237m ±  7%   9.633m ±  8%  +33.11% (p=0.002 n=6)
SerializeNative/STEFU/serialize-4                    33.01m ±  2%   33.68m ±  2%   +2.04% (p=0.041 n=6)
DeserializeNative/STEF/deser-4                       2.623m ±  1%   2.619m ±  1%        ~ (p=0.937 n=6)
DeserializeNative/STEFU/deser-4                      7.522m ±  0%   7.509m ±  1%        ~ (p=0.310 n=6)
SerializeFromPdata/STEF/serialize-4                  138.4m ±  3%   137.0m ±  2%        ~ (p=0.394 n=6)
SerializeFromPdata/STEFU/serialize-4                 34.00m ±  1%   33.32m ±  1%   -1.98% (p=0.004 n=6)
DeserializeToPdata/STEF/deserialize-4                40.21m ±  3%   40.60m ±  1%        ~ (p=0.310 n=6)
DeserializeToPdata/STEFU/deserialize-4               57.24m ±  2%   57.48m ±  2%        ~ (p=0.394 n=6)
STEFReaderRead-4                                     2.655m ±  1%   2.638m ±  1%        ~ (p=0.240 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4        3.228 ± 23%    3.375 ± 22%        ~ (p=0.394 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     80.61m ± 11%   82.37m ± 11%        ~ (p=0.589 n=6)
ReadSTEF-4                                           2.817m ±  1%   2.701m ±  1%   -4.13% (p=0.002 n=6)
ReadSTEFZ-4                                          4.286m ±  2%   4.213m ±  1%        ~ (p=0.132 n=6)
ReadSTEFZWriteSTEF-4                                 7.897m ±  0%   7.597m ±  2%   -3.79% (p=0.002 n=6)
geomean                                              21.05m         21.43m         +1.79%

                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │   sec/point    │  sec/point    vs base               │
SerializeNative/STEF/serialize-4                     108.2n ±  7%   144.1n ±  8%  +33.13% (p=0.002 n=6)
SerializeNative/STEFU/serialize-4                    493.6n ±  2%   503.7n ±  2%   +2.05% (p=0.039 n=6)
DeserializeNative/STEF/deser-4                       39.24n ±  1%   39.17n ±  1%        ~ (p=0.937 n=6)
DeserializeNative/STEFU/deser-4                      112.5n ±  0%   112.3n ±  1%        ~ (p=0.284 n=6)
SerializeFromPdata/STEF/serialize-4                  2.071µ ±  3%   2.049µ ±  2%        ~ (p=0.368 n=6)
SerializeFromPdata/STEFU/serialize-4                 508.4n ±  1%   498.4n ±  1%   -1.98% (p=0.004 n=6)
DeserializeToPdata/STEF/deserialize-4                601.5n ±  3%   607.3n ±  1%        ~ (p=0.310 n=6)
DeserializeToPdata/STEFU/deserialize-4               856.1n ±  2%   859.8n ±  2%        ~ (p=0.394 n=6)
STEFReaderRead-4                                     39.70n ±  1%   39.46n ±  1%        ~ (p=0.240 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4       4.103µ ± 23%   4.290µ ± 22%        ~ (p=0.394 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     102.5n ± 11%   104.7n ± 11%        ~ (p=0.589 n=6)
ReadSTEF-4                                           42.16n ±  1%   40.42n ±  1%   -4.13% (p=0.002 n=6)
ReadSTEFZ-4                                          64.14n ±  2%   63.05n ±  1%        ~ (p=0.132 n=6)
ReadSTEFZWriteSTEF-4                                 118.2n ±  0%   113.7n ±  2%   -3.81% (p=0.002 n=6)
geomean                                              221.4n         225.4n         +1.79%

                                                 │ bench-main.txt │            bench-new.txt             │
                                                 │      B/op      │     B/op      vs base                │
SerializeNative/STEF/serialize-4                     3.340Mi ± 0%   3.340Mi ± 0%       ~ (p=0.589 n=6)
SerializeNative/STEFU/serialize-4                    7.530Mi ± 0%   7.530Mi ± 0%       ~ (p=0.387 n=6)
DeserializeNative/STEF/deser-4                       934.2Ki ± 0%   934.2Ki ± 0%       ~ (p=1.000 n=6) ¹
DeserializeNative/STEFU/deser-4                      1.470Mi ± 0%   1.470Mi ± 0%       ~ (p=1.000 n=6)
SerializeFromPdata/STEF/serialize-4                  74.82Mi ± 0%   74.82Mi ± 0%       ~ (p=0.658 n=6)
SerializeFromPdata/STEFU/serialize-4                 7.530Mi ± 0%   7.530Mi ± 0%       ~ (p=0.667 n=6)
DeserializeToPdata/STEF/deserialize-4                29.91Mi ± 0%   29.91Mi ± 0%       ~ (p=0.247 n=6)
DeserializeToPdata/STEFU/deserialize-4               36.53Mi ± 0%   36.53Mi ± 0%       ~ (p=0.558 n=6)
STEFReaderRead-4                                     935.9Ki ± 0%   935.9Ki ± 0%       ~ (p=1.000 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4       3.360Gi ± 0%   3.360Gi ± 0%       ~ (p=0.699 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     20.40Mi ± 0%   20.40Mi ± 0%       ~ (p=0.903 n=6)
ReadSTEF-4                                           935.9Ki ± 0%   935.9Ki ± 0%       ~ (p=0.273 n=6)
ReadSTEFZ-4                                          10.27Mi ± 0%   10.27Mi ± 0%       ~ (p=0.132 n=6)
ReadSTEFZWriteSTEF-4                                 13.43Mi ± 0%   13.43Mi ± 0%       ~ (p=0.071 n=6)
geomean                                              10.38Mi        10.38Mi       +0.00%
¹ all samples are equal

                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │   allocs/op    │  allocs/op   vs base                │
SerializeNative/STEF/serialize-4                      2.648k ± 0%   2.649k ± 0%       ~ (p=0.619 n=6)
SerializeNative/STEFU/serialize-4                      884.0 ± 0%    884.0 ± 0%       ~ (p=1.000 n=6)
DeserializeNative/STEF/deser-4                         465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
DeserializeNative/STEFU/deser-4                        469.0 ± 0%    469.0 ± 0%       ~ (p=1.000 n=6) ¹
SerializeFromPdata/STEF/serialize-4                   134.7k ± 0%   134.7k ± 0%       ~ (p=0.563 n=6)
SerializeFromPdata/STEFU/serialize-4                   886.0 ± 0%    886.0 ± 0%       ~ (p=1.000 n=6)
DeserializeToPdata/STEF/deserialize-4                 622.5k ± 0%   622.5k ± 0%       ~ (p=1.000 n=6)
DeserializeToPdata/STEFU/deserialize-4                811.2k ± 0%   811.2k ± 0%       ~ (p=1.000 n=6) ¹
STEFReaderRead-4                                       465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
STEFSerializeMultipart/astronomy-otelmetrics-4        13.15M ± 0%   13.15M ± 0%       ~ (p=0.485 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4      2.293k ± 0%   2.293k ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEF-4                                             465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEFZ-4                                            501.0 ± 0%    501.0 ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEFZWriteSTEF-4                                  1.233k ± 0%   1.232k ± 0%       ~ (p=0.567 n=6)
geomean                                               6.200k        6.200k       -0.00%
¹ all samples are equal
Benchmark result
benchstat bench-new.txt
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-new.txt │
                                                 │    sec/op     │
SerializeNative/STEF/serialize-4                    9.633m ±  8%
SerializeNative/STEFU/serialize-4                   33.68m ±  2%
DeserializeNative/STEF/deser-4                      2.619m ±  1%
DeserializeNative/STEFU/deser-4                     7.509m ±  1%
SerializeFromPdata/STEF/serialize-4                 137.0m ±  2%
SerializeFromPdata/STEFU/serialize-4                33.32m ±  1%
DeserializeToPdata/STEF/deserialize-4               40.60m ±  1%
DeserializeToPdata/STEFU/deserialize-4              57.48m ±  2%
STEFReaderRead-4                                    2.638m ±  1%
STEFSerializeMultipart/astronomy-otelmetrics-4       3.375 ± 22%
STEFDeserializeMultipart/astronomy-otelmetrics-4    82.37m ± 11%
ReadSTEF-4                                          2.701m ±  1%
ReadSTEFZ-4                                         4.213m ±  1%
ReadSTEFZWriteSTEF-4                                7.597m ±  2%
geomean                                             21.43m

                                                 │ bench-new.txt │
                                                 │   sec/point   │
SerializeNative/STEF/serialize-4                    144.1n ±  8%
SerializeNative/STEFU/serialize-4                   503.7n ±  2%
DeserializeNative/STEF/deser-4                      39.17n ±  1%
DeserializeNative/STEFU/deser-4                     112.3n ±  1%
SerializeFromPdata/STEF/serialize-4                 2.049µ ±  2%
SerializeFromPdata/STEFU/serialize-4                498.4n ±  1%
DeserializeToPdata/STEF/deserialize-4               607.3n ±  1%
DeserializeToPdata/STEFU/deserialize-4              859.8n ±  2%
STEFReaderRead-4                                    39.46n ±  1%
STEFSerializeMultipart/astronomy-otelmetrics-4      4.290µ ± 22%
STEFDeserializeMultipart/astronomy-otelmetrics-4    104.7n ± 11%
ReadSTEF-4                                          40.42n ±  1%
ReadSTEFZ-4                                         63.05n ±  1%
ReadSTEFZWriteSTEF-4                                113.7n ±  2%
geomean                                             225.4n

                                                 │ bench-new.txt │
                                                 │     B/op      │
SerializeNative/STEF/serialize-4                    3.340Mi ± 0%
SerializeNative/STEFU/serialize-4                   7.530Mi ± 0%
DeserializeNative/STEF/deser-4                      934.2Ki ± 0%
DeserializeNative/STEFU/deser-4                     1.470Mi ± 0%
SerializeFromPdata/STEF/serialize-4                 74.82Mi ± 0%
SerializeFromPdata/STEFU/serialize-4                7.530Mi ± 0%
DeserializeToPdata/STEF/deserialize-4               29.91Mi ± 0%
DeserializeToPdata/STEFU/deserialize-4              36.53Mi ± 0%
STEFReaderRead-4                                    935.9Ki ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4      3.360Gi ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4    20.40Mi ± 0%
ReadSTEF-4                                          935.9Ki ± 0%
ReadSTEFZ-4                                         10.27Mi ± 0%
ReadSTEFZWriteSTEF-4                                13.43Mi ± 0%
geomean                                             10.38Mi

                                                 │ bench-new.txt │
                                                 │   allocs/op   │
SerializeNative/STEF/serialize-4                     2.649k ± 0%
SerializeNative/STEFU/serialize-4                     884.0 ± 0%
DeserializeNative/STEF/deser-4                        465.0 ± 0%
DeserializeNative/STEFU/deser-4                       469.0 ± 0%
SerializeFromPdata/STEF/serialize-4                  134.7k ± 0%
SerializeFromPdata/STEFU/serialize-4                  886.0 ± 0%
DeserializeToPdata/STEF/deserialize-4                622.5k ± 0%
DeserializeToPdata/STEFU/deserialize-4               811.2k ± 0%
STEFReaderRead-4                                      465.0 ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4       13.15M ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4     2.293k ± 0%
ReadSTEF-4                                            465.0 ± 0%
ReadSTEFZ-4                                           501.0 ± 0%
ReadSTEFZWriteSTEF-4                                 1.232k ± 0%
geomean                                              6.200k

@tigrannajaryan tigrannajaryan merged commit 6feb1bc into main Sep 25, 2025
10 checks passed
@tigrannajaryan tigrannajaryan deleted the tigran/prep008 branch September 25, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants