Skip to content

Conversation

@tigrannajaryan
Copy link
Collaborator

Replaces #175

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

Benchmark Result

Benchmark diff with base branch
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │     sec/op     │    sec/op     vs base               │
SerializeNative/STEF/serialize-4                     12.83m ±  3%   12.72m ±  8%        ~ (p=0.818 n=6)
SerializeNative/STEFU/serialize-4                    34.85m ±  1%   34.58m ±  2%   -0.79% (p=0.041 n=6)
DeserializeNative/STEF/deser-4                       2.606m ±  3%   2.619m ±  1%        ~ (p=0.394 n=6)
DeserializeNative/STEFU/deser-4                      7.448m ±  1%   7.472m ±  0%        ~ (p=0.589 n=6)
SerializeFromPdata/STEF/serialize-4                  152.9m ±  3%   138.8m ±  6%   -9.22% (p=0.002 n=6)
SerializeFromPdata/STEFU/serialize-4                 35.09m ±  1%   35.14m ±  2%        ~ (p=0.937 n=6)
DeserializeToPdata/STEF/deserialize-4                40.78m ±  2%   40.88m ±  2%        ~ (p=0.818 n=6)
DeserializeToPdata/STEFU/deserialize-4               58.00m ±  2%   58.49m ±  3%        ~ (p=0.589 n=6)
STEFReaderRead-4                                     2.647m ±  1%   2.655m ±  1%        ~ (p=0.240 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4        3.513 ± 21%    3.254 ± 26%        ~ (p=0.065 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     79.24m ±  9%   79.03m ±  9%        ~ (p=0.589 n=6)
ReadSTEF-4                                           2.798m ±  1%   2.782m ±  1%   -0.57% (p=0.026 n=6)
ReadSTEFZ-4                                          4.949m ±  2%   4.160m ±  1%  -15.94% (p=0.002 n=6)
ReadSTEFZWriteSTEF-4                                 7.892m ±  1%   7.769m ±  1%   -1.56% (p=0.009 n=6)
geomean                                              22.56m         21.98m         -2.57%

                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │   sec/point    │  sec/point    vs base               │
SerializeNative/STEF/serialize-4                     191.9n ±  3%   190.2n ±  8%        ~ (p=0.818 n=6)
SerializeNative/STEFU/serialize-4                    521.3n ±  1%   517.1n ±  2%   -0.79% (p=0.041 n=6)
DeserializeNative/STEF/deser-4                       38.98n ±  3%   39.17n ±  1%        ~ (p=0.381 n=6)
DeserializeNative/STEFU/deser-4                      111.3n ±  1%   111.8n ±  0%        ~ (p=0.509 n=6)
SerializeFromPdata/STEF/serialize-4                  2.287µ ±  3%   2.076µ ±  6%   -9.23% (p=0.002 n=6)
SerializeFromPdata/STEFU/serialize-4                 524.8n ±  1%   525.5n ±  2%        ~ (p=0.937 n=6)
DeserializeToPdata/STEF/deserialize-4                609.9n ±  2%   611.4n ±  2%        ~ (p=0.818 n=6)
DeserializeToPdata/STEFU/deserialize-4               867.5n ±  2%   874.8n ±  3%        ~ (p=0.558 n=6)
STEFReaderRead-4                                     39.59n ±  1%   39.70n ±  1%        ~ (p=0.225 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4       4.465µ ± 21%   4.136µ ± 26%        ~ (p=0.065 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     100.7n ±  9%   100.5n ±  9%        ~ (p=0.515 n=6)
ReadSTEF-4                                           41.87n ±  1%   41.63n ±  1%   -0.57% (p=0.026 n=6)
ReadSTEFZ-4                                          74.06n ±  2%   62.26n ±  1%  -15.94% (p=0.002 n=6)
ReadSTEFZWriteSTEF-4                                 118.2n ±  1%   116.3n ±  1%   -1.57% (p=0.009 n=6)
geomean                                              237.3n         231.2n         -2.57%

                                                 │ bench-main.txt │            bench-new.txt             │
                                                 │      B/op      │     B/op      vs base                │
SerializeNative/STEF/serialize-4                     3.349Mi ± 0%   3.349Mi ± 0%       ~ (p=0.937 n=6)
SerializeNative/STEFU/serialize-4                    7.530Mi ± 0%   7.530Mi ± 0%       ~ (p=0.812 n=6)
DeserializeNative/STEF/deser-4                       934.2Ki ± 0%   934.2Ki ± 0%       ~ (p=1.000 n=6) ¹
DeserializeNative/STEFU/deser-4                      1.470Mi ± 0%   1.470Mi ± 0%       ~ (p=1.000 n=6) ¹
SerializeFromPdata/STEF/serialize-4                  74.82Mi ± 0%   74.82Mi ± 0%       ~ (p=0.052 n=6)
SerializeFromPdata/STEFU/serialize-4                 7.530Mi ± 0%   7.530Mi ± 0%       ~ (p=0.519 n=6)
DeserializeToPdata/STEF/deserialize-4                29.91Mi ± 0%   29.91Mi ± 0%       ~ (p=0.957 n=6)
DeserializeToPdata/STEFU/deserialize-4               36.53Mi ± 0%   36.53Mi ± 0%       ~ (p=0.089 n=6)
STEFReaderRead-4                                     935.9Ki ± 0%   935.9Ki ± 0%       ~ (p=1.000 n=6) ¹
STEFSerializeMultipart/astronomy-otelmetrics-4       3.362Gi ± 0%   3.360Gi ± 0%       ~ (p=0.394 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     20.40Mi ± 0%   20.40Mi ± 0%       ~ (p=0.708 n=6)
ReadSTEF-4                                           935.9Ki ± 0%   935.9Ki ± 0%       ~ (p=0.273 n=6)
ReadSTEFZ-4                                          10.27Mi ± 0%   10.27Mi ± 0%       ~ (p=0.132 n=6)
ReadSTEFZWriteSTEF-4                                 13.43Mi ± 0%   13.43Mi ± 0%       ~ (p=0.180 n=6)
geomean                                              10.38Mi        10.38Mi       -0.00%
¹ all samples are equal

                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │   allocs/op    │  allocs/op   vs base                │
SerializeNative/STEF/serialize-4                      2.666k ± 0%   2.667k ± 0%       ~ (p=0.779 n=6)
SerializeNative/STEFU/serialize-4                      884.0 ± 0%    884.0 ± 0%       ~ (p=1.000 n=6)
DeserializeNative/STEF/deser-4                         465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
DeserializeNative/STEFU/deser-4                        469.0 ± 0%    469.0 ± 0%       ~ (p=1.000 n=6) ¹
SerializeFromPdata/STEF/serialize-4                   134.7k ± 0%   134.7k ± 0%       ~ (p=0.385 n=6)
SerializeFromPdata/STEFU/serialize-4                   886.0 ± 0%    886.0 ± 0%       ~ (p=1.000 n=6) ¹
DeserializeToPdata/STEF/deserialize-4                 622.5k ± 0%   622.5k ± 0%       ~ (p=1.000 n=6)
DeserializeToPdata/STEFU/deserialize-4                811.2k ± 0%   811.2k ± 0%       ~ (p=1.000 n=6) ¹
STEFReaderRead-4                                       465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
STEFSerializeMultipart/astronomy-otelmetrics-4        13.15M ± 0%   13.15M ± 0%       ~ (p=0.180 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4      2.293k ± 0%   2.293k ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEF-4                                             465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEFZ-4                                            501.0 ± 0%    501.0 ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEFZWriteSTEF-4                                  1.233k ± 0%   1.232k ± 0%       ~ (p=0.567 n=6)
geomean                                               6.203k        6.202k       -0.00%
¹ all samples are equal
Benchmark result
benchstat bench-new.txt
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-new.txt │
                                                 │    sec/op     │
SerializeNative/STEF/serialize-4                    12.72m ±  8%
SerializeNative/STEFU/serialize-4                   34.58m ±  2%
DeserializeNative/STEF/deser-4                      2.619m ±  1%
DeserializeNative/STEFU/deser-4                     7.472m ±  0%
SerializeFromPdata/STEF/serialize-4                 138.8m ±  6%
SerializeFromPdata/STEFU/serialize-4                35.14m ±  2%
DeserializeToPdata/STEF/deserialize-4               40.88m ±  2%
DeserializeToPdata/STEFU/deserialize-4              58.49m ±  3%
STEFReaderRead-4                                    2.655m ±  1%
STEFSerializeMultipart/astronomy-otelmetrics-4       3.254 ± 26%
STEFDeserializeMultipart/astronomy-otelmetrics-4    79.03m ±  9%
ReadSTEF-4                                          2.782m ±  1%
ReadSTEFZ-4                                         4.160m ±  1%
ReadSTEFZWriteSTEF-4                                7.769m ±  1%
geomean                                             21.98m

                                                 │ bench-new.txt │
                                                 │   sec/point   │
SerializeNative/STEF/serialize-4                    190.2n ±  8%
SerializeNative/STEFU/serialize-4                   517.1n ±  2%
DeserializeNative/STEF/deser-4                      39.17n ±  1%
DeserializeNative/STEFU/deser-4                     111.8n ±  0%
SerializeFromPdata/STEF/serialize-4                 2.076µ ±  6%
SerializeFromPdata/STEFU/serialize-4                525.5n ±  2%
DeserializeToPdata/STEF/deserialize-4               611.4n ±  2%
DeserializeToPdata/STEFU/deserialize-4              874.8n ±  3%
STEFReaderRead-4                                    39.70n ±  1%
STEFSerializeMultipart/astronomy-otelmetrics-4      4.136µ ± 26%
STEFDeserializeMultipart/astronomy-otelmetrics-4    100.5n ±  9%
ReadSTEF-4                                          41.63n ±  1%
ReadSTEFZ-4                                         62.26n ±  1%
ReadSTEFZWriteSTEF-4                                116.3n ±  1%
geomean                                             231.2n

                                                 │ bench-new.txt │
                                                 │     B/op      │
SerializeNative/STEF/serialize-4                    3.349Mi ± 0%
SerializeNative/STEFU/serialize-4                   7.530Mi ± 0%
DeserializeNative/STEF/deser-4                      934.2Ki ± 0%
DeserializeNative/STEFU/deser-4                     1.470Mi ± 0%
SerializeFromPdata/STEF/serialize-4                 74.82Mi ± 0%
SerializeFromPdata/STEFU/serialize-4                7.530Mi ± 0%
DeserializeToPdata/STEF/deserialize-4               29.91Mi ± 0%
DeserializeToPdata/STEFU/deserialize-4              36.53Mi ± 0%
STEFReaderRead-4                                    935.9Ki ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4      3.360Gi ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4    20.40Mi ± 0%
ReadSTEF-4                                          935.9Ki ± 0%
ReadSTEFZ-4                                         10.27Mi ± 0%
ReadSTEFZWriteSTEF-4                                13.43Mi ± 0%
geomean                                             10.38Mi

                                                 │ bench-new.txt │
                                                 │   allocs/op   │
SerializeNative/STEF/serialize-4                     2.667k ± 0%
SerializeNative/STEFU/serialize-4                     884.0 ± 0%
DeserializeNative/STEF/deser-4                        465.0 ± 0%
DeserializeNative/STEFU/deser-4                       469.0 ± 0%
SerializeFromPdata/STEF/serialize-4                  134.7k ± 0%
SerializeFromPdata/STEFU/serialize-4                  886.0 ± 0%
DeserializeToPdata/STEF/deserialize-4                622.5k ± 0%
DeserializeToPdata/STEFU/deserialize-4               811.2k ± 0%
STEFReaderRead-4                                      465.0 ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4       13.15M ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4     2.293k ± 0%
ReadSTEF-4                                            465.0 ± 0%
ReadSTEFZ-4                                           501.0 ± 0%
ReadSTEFZWriteSTEF-4                                 1.232k ± 0%
geomean                                              6.202k

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the google.golang.org/protobuf dependency from various older versions (1.35.2, 1.36.5) to version 1.36.9 across multiple Go modules in the project. It also standardizes the Go version to 1.23.2 across all modules and adds a new gotidy target to the Makefile.

  • Updates google.golang.org/protobuf dependency to version 1.36.9
  • Standardizes Go version to 1.23.2 across all modules
  • Adds a gotidy Makefile target for running go mod tidy on all modules

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
stefc/go.mod Updates Go version from 1.22.7 to 1.23.2
stefc/generator/testdata/go.mod Updates Go version from 1.24 to 1.23.2
otelcol/internal/tools/go.mod Updates Go version from 1.21.0 to 1.23.2 and removes toolchain specification
otelcol/go.mod Updates Go version to 1.23.2, removes toolchain, and bumps protobuf to 1.36.9
makefile Adds new gotidy target for running go mod tidy across all modules
go/pkg/go.mod Updates Go version from 1.22.7 to 1.23.2
go/pdata/go.mod Updates Go version to 1.23.2, removes toolchain, and bumps protobuf to 1.36.9
go/otel/go.mod Updates Go version to 1.23.2, removes toolchain, and bumps protobuf to 1.36.9
go/grpc/go.mod Updates Go version to 1.23.2, removes toolchain, and bumps protobuf to 1.36.9
examples/jsonl/go.mod Updates Go version from 1.23 to 1.23.2

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tigrannajaryan tigrannajaryan merged commit 2fe281d into main Sep 30, 2025
10 checks passed
@tigrannajaryan tigrannajaryan deleted the tigran/update-protobuf branch September 30, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants