Use the supplied launcher artwork - #10
Merged
Merged
Conversation
The old icon was the source art flattened into an opaque 432px square, which hid the background layer entirely and left launchers sliding a black rectangle during parallax. The artwork now goes in as drawn. Android only ever shows the central 72 of the 108dp canvas, so it is padded to that ratio in matched black: the mask crops the padding and never the composition. Ships as real density buckets, with a monochrome silhouette traced from the ghost so themed icons do not fall back to Android's generated one.
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher icon was the source art flattened into an opaque 432px square. That hid the background layer completely, so
<background>never rendered and launchers parallaxed a black rectangle across it during scroll and press, with the baked vignette cropped differently by every mask.The artwork now goes in as drawn, with no edit to the composition.
The one thing that needed care
Android only ever shows the central 72 of a 108dp canvas. Dropping a finished square straight in means a third of it disappears and the subject balloons: measured, the ghost is 58% of the supplied art, which would have become 87% of the visible area, jammed against the mask.
So the art is padded outward to that ratio in
#0C0C0C, matching its own measured edge tone. The mask crops the padding I added and nothing that was drawn. The ghost lands at 58% of the visible area, inside the 66dp safe circle.Also
Ships as real density buckets rather than one oversized bitmap the system rescales on every draw, about 128KB total. The monochrome layer is a silhouette traced from the ghost at the same position and scale, verified within 2px of the original bounds. Without it Android generates its own for themed icons and the result is reliably bad.
Verified on the emulator in the app drawer and rendered under circle, squircle, rounded-square, and themed masks: the ghost is whole in all four. Lint also caught the now-unused
ic_launcher_backgroundcolour, which is removed.