feat: rework per-link stats onto the new analytics surface - #5
Merged
Conversation
GET /api/v1/stats is dropping the scope param and going auth-only.
Authed lookups now resolve alias to url_id via /urls/{domain}/{alias}
and read /stats/links/{url_id}; anonymous or foreign links fall back
to /public/stats/{code}. The v0 stats fallback is removed.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughChangesStatistics flow
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant User
participant AnalyticsTab
participant StatsHooks
participant StatsAPI
participant URLAPI
User->>AnalyticsTab: Open analytics
AnalyticsTab->>StatsHooks: Request account or URL stats
StatsHooks->>StatsAPI: Fetch statistics
StatsAPI->>URLAPI: Resolve owned URL
URLAPI-->>StatsAPI: Return URL or no match
StatsAPI-->>StatsHooks: Return owned or public stats
StatsHooks-->>AnalyticsTab: Return data or StatsUnavailableError
AnalyticsTab-->>User: Render metrics or status text
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the API change in spoo-me/spoo#291/#292 and removes the v0 stats fallback.
GET /api/v1/urls/{domain}/{alias}and read the authedGET /api/v1/stats/links/{id}; anonymous users, and codes outside the account, useGET /api/v1/public/stats/{code}.avg_redirection_timeis nullable now, matching the wire; the old schema rejected zero-click windows.Kept tightly scoped to the stats module so the PKCE branch rebases cleanly. Typecheck, lint, and build pass.
Summary by CodeRabbit
New Features
Bug Fixes