Skip to content

refactor: simplify error page layout - #144

Merged
Zingzy merged 1 commit into
mainfrom
fix/error-page-hediousness
Mar 31, 2026
Merged

refactor: simplify error page layout #144
Zingzy merged 1 commit into
mainfrom
fix/error-page-hediousness

Conversation

@Zingzy

@Zingzy Zingzy commented Mar 31, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Simplify the error page layout and styling by removing decorative effects and custom button container.

Enhancements:

  • Replace the glitch-styled error message with a simpler static text presentation.
  • Remove the styled button container and home button from the error page template and associated CSS.
  • Streamline error page CSS to only include basic typography styling for the error message text.
  • Bump the error page stylesheet version query parameter to ensure clients load the updated styles.

Copilot AI review requested due to automatic review settings March 31, 2026 11:30
@Zingzy Zingzy self-assigned this Mar 31, 2026
@sourcery-ai

sourcery-ai Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR simplifies the error page by removing the animated glitch heading and button container, replacing them with a single static text element and corresponding minimal CSS, and bumps the error stylesheet version reference.

File-Level Changes

Change Details Files
Simplified error page HTML structure and removed the styled Home button container.
  • Replaced the glitch-wrapper/glitch heading with a simple div using a new error-text class to display error_code and error_message.
  • Removed the container and btn markup that rendered the animated Home button.
  • Updated the error.css asset URL query parameter from v=1 to v=2 to bust caches.
templates/error.html
Removed complex glitch and button styles, replacing them with a minimal error text style.
  • Deleted .container, .btn, and related hover/animation styles for the Home button layout.
  • Removed .glitch-wrapper, .glitch, and @Keyframes glitch-color definitions that produced the animated glitch effect.
  • Added a new .error-text class that preserves the previous font sizing, weight, color, and spacing while simplifying layout and margins.
static/css/error.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Zingzy Zingzy added frontend ✨ Refactor Pull requests that refactors the codebase labels Mar 31, 2026
@Zingzy Zingzy moved this to 🏗️ In Progress in spoo.me Development Roadmap Mar 31, 2026
@Zingzy Zingzy added this to the Advanced Features and Security milestone Mar 31, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="templates/error.html" line_range="30-31" />
<code_context>
-        </div>
+        <div class="error-text">{{ error_code }}, {{ error_message }}</div>
     </div>
-    <div class="container">
-        <div class="btn"><a href="/"><pre>Home</pre></a></div>
-    </div>
-{% endblock %}
</code_context>
<issue_to_address>
**question:** Removing the Home button may impact navigation from error pages.

This change removes a clear recovery path for users who hit this error (e.g., via deep links without visible navigation). If the main layout doesn’t already provide an obvious way back, consider keeping a small link to the homepage or a help page here.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread templates/error.html
Comment on lines -30 to -31
<div class="container">
<div class="btn"><a href="/"><pre>Home</pre></a></div>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Removing the Home button may impact navigation from error pages.

This change removes a clear recovery path for users who hit this error (e.g., via deep links without visible navigation). If the main layout doesn’t already provide an obvious way back, consider keeping a small link to the homepage or a help page here.

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@Zingzy has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 55 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 14 minutes and 55 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4ffeb385-ee5d-4d8d-a156-8d9aa5119ac4

📥 Commits

Reviewing files that changed from the base of the PR and between 84a21c0 and 0725f5f.

📒 Files selected for processing (2)
  • static/css/error.css
  • templates/error.html
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/error-page-hediousness

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the HTML/CSS for the browser error page to remove the “glitch” effect and simplify the layout/styling.

Changes:

  • Simplified templates/error.html markup by removing the glitch wrapper and the Home button container.
  • Removed the corresponding button + glitch animation CSS and introduced a simple .error-text style.
  • Bumped the cache-busting query param for error.css from v=1 to v=2.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
templates/error.html Simplifies error page content structure and updates the referenced stylesheet version.
static/css/error.css Removes unused glitch/button styling and adds a simpler .error-text rule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread templates/error.html
@Zingzy
Zingzy merged commit 158d0ce into main Mar 31, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from 🏗️ In Progress to ✔️ Done in spoo.me Development Roadmap Mar 31, 2026
@Zingzy
Zingzy deleted the fix/error-page-hediousness branch August 16, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ✨ Refactor Pull requests that refactors the codebase

Projects

Status: ✔️ Done

Development

Successfully merging this pull request may close these issues.

2 participants