Skip to content

chore: ship click worker logs to axiom - #217

Merged
Zingzy merged 1 commit into
mainfrom
chore/vector-worker-logs
Jul 4, 2026
Merged

chore: ship click worker logs to axiom#217
Zingzy merged 1 commit into
mainfrom
chore/vector-worker-logs

Conversation

@Zingzy

@Zingzy Zingzy commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Enhancements:

  • Include the spoo_click_worker container in the docker log source configuration and JSON parsing transform to ensure its logs are collected and structured.

Summary by CodeRabbit

  • Bug Fixes
    • Improved Docker log handling so events from an additional container are now captured and parsed correctly.
    • This helps ensure logs appear consistently across more services, reducing missing or malformed log entries.

Copilot AI review requested due to automatic review settings July 4, 2026 08:59
@sourcery-ai

sourcery-ai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configure Vector to collect and parse logs from the new spoo_click_worker container alongside existing app and QR services.

Flow diagram for Vector log shipping including spoo_click_worker

flowchart LR
    spoo_app[spoo_app container]
    spoo_qr[spoo_qr container]
    spoo_click_worker[spoo_click_worker container]
    docker_source[sources.docker]
    parse_and_clean[transforms.parse_and_clean]
    axiom_sink[axiom sink]

    spoo_app --> docker_source
    spoo_qr --> docker_source
    spoo_click_worker --> docker_source
    docker_source --> parse_and_clean
    parse_and_clean --> axiom_sink
Loading

File-Level Changes

Change Details Files
Start ingesting docker logs from the new click worker container and apply the same JSON parsing/cleanup transform as other app containers.
  • Extend the docker_logs source configuration to include the spoo_click_worker container in the include_containers list.
  • Update the parse_and_clean transform condition to treat spoo_click_worker logs like spoo_app and spoo_qr, applying JSON parsing and field merging when the container_name matches.
vector.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9815de15-198e-4e03-93ab-db85eb675c0f

📥 Commits

Reviewing files that changed from the base of the PR and between 22da664 and 29b6d52.

📒 Files selected for processing (1)
  • vector.toml

📝 Walkthrough

Walkthrough

Modified vector.toml to add the spoo_click_worker container to the Docker logs source's include_containers list and to the conditional logic in the parse_and_clean transform that gates JSON parsing for specific containers.

Changes

Vector logging config

Layer / File(s) Summary
Include spoo_click_worker in log source and parsing
vector.toml
Adds spoo_click_worker to the Docker source's include_containers allowlist and to the transform condition that parses/lifts JSON events for specific containers.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects shipping click worker logs to Axiom, which matches the Vector logging changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/vector-worker-logs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The container name list is duplicated between include_containers and the parse_and_clean transform condition; consider centralizing or pattern-based matching (e.g., checking a prefix or using a shared list) to avoid future drift when adding/removing containers.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The container name list is duplicated between `include_containers` and the `parse_and_clean` transform condition; consider centralizing or pattern-based matching (e.g., checking a prefix or using a shared list) to avoid future drift when adding/removing containers.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Zingzy
Zingzy merged commit 988116f into main Jul 4, 2026
7 of 8 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Vector log shipping configuration so logs from the spoo_click_worker Docker container are collected and (when applicable) JSON-parsed before being shipped to Axiom.

Changes:

  • Add spoo_click_worker to the Docker log source container allowlist.
  • Extend the VRL remap transform’s JSON parsing condition to include spoo_click_worker.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread vector.toml
.service = .container_name

if .container_name == "spoo_app" || .container_name == "spoo_qr" {
if .container_name == "spoo_app" || .container_name == "spoo_qr" || .container_name == "spoo_click_worker" {
@Zingzy
Zingzy deleted the chore/vector-worker-logs branch August 16, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✔️ Done

Development

Successfully merging this pull request may close these issues.

2 participants