-
Notifications
You must be signed in to change notification settings - Fork 12
add picke visual media api #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
(Toast.makeText(cordova.getContext(), toastMsg, Toast.LENGTH_LONG)).show(); | ||
} | ||
private void showMaxLimitWarning(int deviceMaxLimit) { | ||
String toastMsg = "The maximumImagesCount:" + this.maxImageCount + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String toastMsg = "The maximumImagesCount:" + this.maxImageCount + | |
String toastMsg = "The maximumImagesCount: " + this.maxImageCount + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use a single method showMaxLimitWarning(boolean useFilePicker, int deviceMaxLimit = null)
since we already know that useFilePicker = false if it's not used?
I think in Java we can't have parameters with default value. I might be wrong. |
yes it's not possible in Java, but we can still check its value |
@sc-nick I wanted to take advantage of the concept of OOP, that is polymorphism, more precisely the method overloading concept |
Co-authored-by: Mouhammad Hashir Hassam Rajah <[email protected]>
Co-authored-by: Mouhammad Hashir Hassam Rajah <[email protected]>
Add the PickVisualMedia api in addition of the file picker