Skip to content

Add category property to IFSCStarter and filter start list by categories (gender) in iCal generation#51

Merged
nicoSWD merged 1 commit into
sportclimbing:mainfrom
kkhsing:main
May 16, 2026
Merged

Add category property to IFSCStarter and filter start list by categories (gender) in iCal generation#51
nicoSWD merged 1 commit into
sportclimbing:mainfrom
kkhsing:main

Conversation

@kkhsing

@kkhsing kkhsing commented May 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@nicoSWD nicoSWD self-assigned this May 15, 2026
@nicoSWD

nicoSWD commented May 15, 2026

Copy link
Copy Markdown
Collaborator

hey @kkhsing! Thank you so much! First PR this project receives!

This is a great patch, I like it! The only potential issue I see is that buildStartList caps the amount of athletes to 40, ordered by score, independent of the gender. So there could potentially be 30 men and 10 women. Maybe it makes sense to change buildStartList to fetch 20 of each gender and then order by score? What do you think?

@nicoSWD nicoSWD merged commit 447fd4b into sportclimbing:main May 16, 2026
1 of 2 checks passed
@kkhsing

kkhsing commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

Hey @nicoSWD , thanks for merging! Yes I do think the setup to fetch 20 of each gender would make a lot of sense.

@nicoSWD

nicoSWD commented May 17, 2026

Copy link
Copy Markdown
Collaborator

@kkhsing thanks for your contribution! And yeah, I will look into this. Also it would be nice to only show athletes that registered for the given discipline. Right now it shows all athletes that signed up for the event, so for example speed climbers are listed in the boulder rounds, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants