Skip to content

Conversation

@mateochr
Copy link
Contributor

No description provided.

@mateochr mateochr force-pushed the default-with-allowed-set branch from 9325431 to e4a05b6 Compare March 31, 2025 15:59

expected =
"""
* `--var...` (`atom`) - a var [default: `foo, bar`]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't better to just inspect the default? It would look like:

Suggested change
* `--var...` (`atom`) - a var [default: `foo, bar`]
* `--var...` (`atom`) - a var [default: `[:foo, :bar]`]

Copy link
Contributor Author

@mateochr mateochr Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but the strings would look like this

image

if you are ok with it i can apply it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the test tho, the normal doc would look ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly this is the escaped string, mix help, and mix docs will look fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to do inspect only when default is list or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can always inspect, #{inspect(...)}

@pnezis pnezis self-assigned this Mar 31, 2025
@mateochr mateochr force-pushed the default-with-allowed-set branch from e4a05b6 to 945505e Compare April 1, 2025 11:25
@pnezis pnezis merged commit 060b834 into sportradar:main Apr 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants