A new type of auth #2532
Open
A new type of auth #2532
+389
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silverarmor
reviewed
Oct 11, 2025
| """ | ||
|
|
||
| # For Linux systems, we follow the XDG Base Directory Specification | ||
| # Check if os is linux |
There was a problem hiding this comment.
Why has this code been modified? Did you force push HEAD? Rebase your edits onto the latest master/dev branch upstream.
This was implemented in #2514
Silverarmor
reviewed
Oct 11, 2025
| redirect_uri = f"http://127.0.0.1:{cls._SERVER_PORT}/redirect" | ||
| auth_url = cls._construct_auth_url(client_id, scope, redirect_uri) | ||
|
|
||
| print("=" * 60) |
There was a problem hiding this comment.
We shouldn't be printing anything. Please follow project code styles.
Silverarmor
reviewed
Oct 11, 2025
| while True: | ||
| server.handle_request() | ||
| except cls._Authorization as auth: | ||
| print("✅ Authorization successful!") |
There was a problem hiding this comment.
Get rid of this AI slop emojis.
Silverarmor
reviewed
Oct 11, 2025
|
|
||
| except Exception as e: | ||
| print(f"❌ Authentication failed: {e}") | ||
| sys.exit(1) |
Silverarmor
reviewed
Oct 11, 2025
| ) | ||
|
|
||
| # Auto-enable browser auth if no custom credentials are provided and browser_auth not explicitly set | ||
| if (not hasattr(arguments, 'browser_auth') or not arguments.browser_auth) and \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new browser-based authentication flow for SpotDL, allowing users to log in to Spotify without needing to create a Spotify Developer App or provide API keys. The implementation includes:
Related Issue
This PR addresses a usability issue for non-technical users like myself who struggle or aren't a fan of API key setup.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate)
N/A (feature is CLI/browser-based)
Types of Changes
New feature (non-breaking change which adds functionality)
My code follows the code style of this project
Main focus: This PR is solely about making authentication easier for users. No other features or refactors are included. Please see AUTH_DOCUMENTATION.md for a full explanation of the new authentication flow.