fix(java): reload state before creating the initial Resolver #104
+172
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
commented
Nov 4, 2025
| cache-from: type=registry,ref=ghcr.io/${{ github.repository }}/cache:main | ||
| secrets: | | ||
| "js_e2e_test_env=${{ secrets.JS_E2E_TEST_ENV }}" | ||
| "java_e2e_test_env=${{ secrets.JS_E2E_TEST_ENV }}" |
There was a problem hiding this comment.
reusing the js e2e test env file due to laziness.
nicklasl
force-pushed
the
java/e2e-tests
branch
from
8b8f6d9 to
9b924dc
Compare
nicklasl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding e2e tests I found a bug where we
sidecarFlagsAdminFetcher.accountIdwas null initially which caused a crash when setting this on a proto object.https://github.com/spotify/confidence-resolver-rust/actions/runs/19079535249/job/54504080290?pr=104#step:5:981
Fixing this by running a
.reload()before trying to create the initial Resolver.Also adds tests.