Skip to content

fix(resolver): surface masked secrets in client secret not found error#410

Merged
nicklasl merged 2 commits into
mainfrom
nicklasl/improve-client-secret-error-message
May 21, 2026
Merged

fix(resolver): surface masked secrets in client secret not found error#410
nicklasl merged 2 commits into
mainfrom
nicklasl/improve-client-secret-error-message

Conversation

@nicklasl
Copy link
Copy Markdown
Member

Summary

  • Improves the "client secret not found" error to show which secret was requested and which ones exist in the state
  • Secrets are masked (first 3 + last 3 chars) to avoid leaking credentials

Test plan

  • cargo clippy -p confidence_resolver passes
  • cargo test -p confidence_resolver --lib — 347 tests pass

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicklasl nicklasl marked this pull request as ready for review May 20, 2026 15:00
@nicklasl nicklasl requested a review from vahidlazio May 20, 2026 15:00
@nicklasl nicklasl force-pushed the nicklasl/improve-client-secret-error-message branch 2 times, most recently from 2155cc6 to 92e1a02 Compare May 21, 2026 06:28
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicklasl nicklasl force-pushed the nicklasl/improve-client-secret-error-message branch from 92e1a02 to 34c3b59 Compare May 21, 2026 06:50
@nicklasl nicklasl merged commit 4ace839 into main May 21, 2026
10 checks passed
@nicklasl nicklasl deleted the nicklasl/improve-client-secret-error-message branch May 21, 2026 06:59
@github-actions github-actions Bot mentioned this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants