Conversation
nicklasl
force-pushed
the
nicklasl/test-reproduce-android-default-value-race-condition
branch
from
c152d27 to
5bef712
Compare
nicklasl
changed the title
nicklasl
force-pushed
the
nicklasl/test-reproduce-android-default-value-race-condition
branch
from
5bef712 to
cc9e526
Compare
nicklasl
changed the title
Tests assert expected behavior: - Stale resolve responses must be discarded when context changes during flight - Flag evaluation returns stale values (not defaults) during re-fetch - FetchAndActivate correctly resolves and activates flags Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Check resolve response context against current context before storing to disk. Prevents storing flag values for an outdated context. - Add @volatile to InMemoryCache.flagResolution for cross-thread visibility on ARM/Android. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nicklasl
force-pushed
the
nicklasl/test-reproduce-android-default-value-race-condition
branch
from
cc9e526 to
0529024
Compare
nicklasl
commented
Mar 13, 2026
Comment on lines
+262
to
+272
| // Discard stale responses: if context changed during the | ||
| // in-flight request, the response is for an outdated context | ||
| if (resolveResponse.data.context == getContext()) { | ||
| diskStorage.store(resolveResponse.data) | ||
| } else { | ||
| debugLogger?.logMessage( | ||
| "Discarding stale resolve response: " + | ||
| "context changed during in-flight request", | ||
| isWarning = true | ||
| ) | ||
| } |
Member
Author
There was a problem hiding this comment.
This is in addition to cancelling the coroutine that makes the network request, so twice the safety?
nicklasl
requested review from
fabriziodemaria,
nickybondarenko and
vahidlazio
as code owners
vahidlazio
approved these changes
Mar 13, 2026
vahidlazio
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes intermittent default value returns on Android:
fetch(): When the evaluation context changes during an in-flight resolve request, the response is now discarded instead of being stored to disk.@VolatileonInMemoryCache.flagResolution: Ensures cross-thread visibility on ARM/Android so writes fromDispatchers.IOare visible to reads on the main thread.Test plan
testStaleResolveResponseDiscardedWhenContextChanged— verified RED without fix, GREEN with fixtestContextChangeTriggersRefetchAndEvaluationDuringFetchReturnsStale— stale evaluation during re-fetchtestFetchAndActivateDoesNotReturnDefaultValues— positive control🤖 Generated with Claude Code