feat: support evict the flag cache #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
requested review from
Billlynch,
andreas-karlsson,
fabriziodemaria,
mfranberg,
vahidlazio and
nickybondarenko
as code owners
nicklasl
force-pushed
the
redefined-cache
branch
3 times, most recently
from
83cf5d1
to
1d67b64
Compare
nicklasl
commented
Jul 12, 2024
packages/sdk/src/Confidence.ts
Outdated
| @@ -147,6 +148,12 @@ export class Confidence implements EventSender, Trackable, FlagResolver { | |||
| } | |||
| } | |||
|
|
|||
| clearFlagCache(): void { | |||
| if (this.config.flagResolverClient instanceof CachingFlagResolverClient) { | |||
| (this.config.flagResolverClient as CachingFlagResolverClient).forceEvict(); | |||
There was a problem hiding this comment.
Not super elegant. We should consider this on the interface.
nicklasl
force-pushed
the
main
branch
3 times, most recently
from
8ffbc18
to
956594b
Compare
nicklasl
force-pushed
the
redefined-cache
branch
from
5fb9c2d
to
a5e783b
Compare
nicklasl
force-pushed
the
redefined-cache
branch
from
a5e783b
to
f621519
Compare
| @@ -124,6 +126,8 @@ export type FlagEvaluation<T> = FlagEvaluation.Resolved<T> | FlagEvaluation.Stal | |||
|
|
|||
| // @public | |||
| export interface FlagResolver extends Contextual<FlagResolver> { | |||
| // (undocumented) | |||
There was a problem hiding this comment.
Please add some docs 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hacky support for manually evicting the Flag Cache if necessary.