Open
Conversation
gijzelaerr
added a commit
to gijzelaerr/pedalboard
that referenced
this pull request
Mar 18, 2026
…metry The scale factor was `pow(2, bitDepth)` which doesn't properly center quantization around zero for signed audio. Changed to `pow(2, bitDepth - 1) + 1` so that the quantization is symmetric. Added tests verifying quantization correctness, symmetry around zero, output range for signed audio, edge cases (bit_depth=1 and 16), and expected number of quantization levels. Fixes spotify#396 Related: spotify#397 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scaleFactor used to multiply the the array to create the representation using new bit depth is
2**bit_depth.But this will result in a representation with more than the expected bits.
The expected formula is: scaleFactor = (2**new_bit_depth)/2+1
New formula reference
Closes #396