Use consistent rounding operations to retrieve all samples from StreamResampler #441
+18
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modest attempt at fixing #287, and sharing the draft to discuss further!
The alternate use of truncation when pulling data from the JUCE buffer and rounding when skipping samples can make us drop a sample sometimes.
Using rounding operations everywhere fixes the issue, but does have the side-effect of modifying the expected final number of samples you'd get when resampling an audio file (round instead of truncation), which seems good enough to me but I could be missing a few subtleties. Happy to discuss!
PS: CI should feel better after #442