ci: Add macOS ARM64 (Apple Silicon) to test matrix#467
Open
gijzelaerr wants to merge 3 commits intospotify:masterfrom
Open
ci: Add macOS ARM64 (Apple Silicon) to test matrix#467gijzelaerr wants to merge 3 commits intospotify:masterfrom
gijzelaerr wants to merge 3 commits intospotify:masterfrom
Conversation
macOS ARM64 wheels are built but were never tested in CI. This adds macos-15 (ARM) runners alongside the existing macos-15-intel (x86_64) runners for Python 3.10-3.14. Also adds an ARM64 entry to the macOS build cache priming job and makes ARCHFLAGS dynamic via the matrix instead of hardcoded to x86_64. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test assumed frames would always be dropped after sleeping for 5 buffer periods, but on ARM macOS CI runners the audio device may have a larger internal buffer. Increase the sleep multiplier and skip gracefully instead of failing when no frames are dropped. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The final assertion in test_read_from_stream_measures_dropped_frames used an exact equality check, but the audio thread can drop one more buffer between the snapshot and stream shutdown. Allow up to one buffer_size of additional dropped frames to avoid spurious failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macos-15(ARM64/Apple Silicon) runners to the CI test matrix for Python 3.10-3.14ARCHFLAGSdynamic via the matrix instead of hardcoded to-arch x86_64Changes
macos-15x Python 3.10-3.14macos-15with Python 3.12ARCHFLAGSnow uses${{ matrix.archflags }}in both cache priming and test jobsTest plan
🤖 Generated with Claude Code