fix: dont override verify attribute when requesting access token#1222
Open
sigma67 wants to merge 3 commits intospotipy-dev:masterfrom
Open
fix: dont override verify attribute when requesting access token#1222sigma67 wants to merge 3 commits intospotipy-dev:masterfrom
sigma67 wants to merge 3 commits intospotipy-dev:masterfrom
Conversation
Member
|
Sounds good. Also would you mind setting up your CI/CD? I just want to make sure that your checks can succeed. Just make sure to add the following variable secrets to your GitHub project settings:
Plus add an entry to the @stephanebruckert anything against it? |
Author
Member
|
Sadly no, the error just says If you want, you can HMU on Discord, maybe I'll be able to help you: https://discord.gg/HP6xcPsTPJ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This call is the only one that overrides the
_session.verifywhich can be passed in via the arguments ofSpotifyClientCredentials.This makes it impossible to actually disable cert verification or set a custom certificate chain (i.e. in a corporate network).
Hence this line should be removed and use the default settings instead, which are provided by the caller.