Open
Conversation
tinomen
reviewed
Feb 14, 2026
|
|
||
| def _get_uri(self, type, id): | ||
| if self._is_uri(id): | ||
| warnings.warn(f"{repr(id)} did not match the Spotify URI RegEx.", UserWarning) |
There was a problem hiding this comment.
Can we be more explicit that it is the Spotify API, since this is quite possible from the spotify apps. I know this is an API library and should be assumed given that context, but ... people.
did not match the Spotify API URI RegEx.
Member
Author
There was a problem hiding this comment.
What would you want in there? Not sure what kind of information we can throw into that message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1221
While implementing, I noticed that such a warning would probably be more disruptive than helpful.
Currently there are multiple methods that should accept both tracks and episodes, but the regex only checks for tracks.
Any thoughts?