Skip to content

docs: add docstring to setup_kubearchive_client()#151

Open
AshleyAHuang wants to merge 1 commit into
spre-sre:mainfrom
AshleyAHuang:docs/add-setup-kubearchive-client-docstring
Open

docs: add docstring to setup_kubearchive_client()#151
AshleyAHuang wants to merge 1 commit into
spre-sre:mainfrom
AshleyAHuang:docs/add-setup-kubearchive-client-docstring

Conversation

@AshleyAHuang

Copy link
Copy Markdown

Closes #122. setup_kubearchive_client() is the entry point for
initializing the cached KubeArchive client singleton, but had no
docstring — callers couldn't tell what the parameters expect, that it
returns None on discovery failure, or that results are cached in the
module-level ka_client global.

Docstring matches the Google-style convention already used elsewhere in
this file (checked against KubeArchiveEndpointDiscovery.discover_endpoint
and KubeArchiveClient.init). No behavior change.

setup_kubearchive_client() is the entry point for initializing the
cached KubeArchive client singleton, but had no docstring — callers
couldn't tell what the parameters expect, that it returns None on
discovery failure, or that results are cached in the module-level
ka_client global.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MEDIUM] setup_kubearchive_client() missing docstring

1 participant