Add scope to show only products which are not assemblies#144
Open
vinay-mittal wants to merge 1 commit into
Open
Add scope to show only products which are not assemblies#144vinay-mittal wants to merge 1 commit into
vinay-mittal wants to merge 1 commit into
Conversation
|
@vinay-mittal @priyank-gupta this PR looks good to me. I think that's a sensible condition to put on parts. Am I correct that this edge case can only happen if someone marks a product that is an assembly as "can be part" in the admin? |
|
@jkelleyj Yeah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scope in the product with name
without_partsis added. As currently when available products are searched, it shows all the products including those which are assemblies.An assembly product should only be able to add only non-assembly products.