Skip to content

Fixes invalid mapping in shared/social partial#215

Open
artplan1 wants to merge 1 commit into
spree-contrib:masterfrom
public-market:fix-devise-mapping-social-partial
Open

Fixes invalid mapping in shared/social partial#215
artplan1 wants to merge 1 commit into
spree-contrib:masterfrom
public-market:fix-devise-mapping-social-partial

Conversation

@artplan1

Copy link
Copy Markdown

Fixes #202

Added tests for account page

Comment thread spec/support/warden.rb
@@ -0,0 +1,3 @@
RSpec.configure do |config|

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

api_secret: 'fake',
environment: Rails.env,
active: true)
create(:authentication_method, provider: 'twitter')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

api_secret: 'fake',
environment: Rails.env,
active: true)
create(:authentication_method, provider: 'facebook')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

end

it 'shows method as connected' do
expect(page).to have_text('You Have Signed In With These Services')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

expect(page).not_to have_link(title: Spree.t(:sign_in_with, provider: authentication_method.provider))
end

it 'shows method as connected' do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

visit '/account'
end

it 'shows possible methods to connect' do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

let!(:authentication_method) { create(:authentication_method) }

before do
visit '/account'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

login_as(user, scope: :spree_user)
end

context 'with existing active authentication methods' do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@@ -0,0 +1,35 @@
RSpec.feature 'account page visit', :js do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [26/25]
Missing magic comment # frozen_string_literal: true.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

FactoryBot.define do
factory :user_authentication, class: Spree::UserAuthentication do
provider 'facebook'
uid 'fake'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants